Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2687903002: Track constant InputDeviceCapabilities objects per-window. (Closed)

Created:
3 years, 10 months ago by sof
Modified:
3 years, 10 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Track constant InputDeviceCapabilities objects per-window. Do not keep global main thread Persistent<>s for the two constant InputDeviceCapabilities objects, as that will end up sharing wrapper objects across contexts. R=dcheng BUG=688569 Review-Url: https://codereview.chromium.org/2675793005 Cr-Commit-Position: refs/heads/master@{#448597} (cherry picked from commit 3867c9867bbb9bbe1d1d4c2c68b60073cb45caaf) Conflicts: third_party/WebKit/Source/core/events/MouseEvent.cpp third_party/WebKit/Source/core/events/TouchEvent.cpp third_party/WebKit/Source/core/frame/DOMWindow.cpp third_party/WebKit/Source/core/frame/DOMWindow.h third_party/WebKit/Source/core/input/EventHandler.cpp Review-Url: https://codereview.chromium.org/2687903002 . Cr-Commit-Position: refs/branch-heads/2987@{#405} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/aca3d111188556531c1f536bc6aff38f2904b059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -58 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/security/cross-frame-mouse-source-capabilities.html View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/resources/cross-frame-mouse-source-capabilities.html View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/CompositionEvent.cpp View 2 chunks +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/events/KeyboardEvent.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/MouseEvent.cpp View 3 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/events/TouchEvent.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/UIEvent.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/UIEvent.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.h View 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.cpp View 4 chunks +9 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/input/GestureManager.cpp View 3 chunks +14 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/input/InputDeviceCapabilities.h View 2 chunks +24 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/input/InputDeviceCapabilities.cpp View 1 chunk +10 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/input/KeyboardEventManager.cpp View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sof
3 years, 10 months ago (2017-02-09 14:56:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aca3d111188556531c1f536bc6aff38f2904b059.

Powered by Google App Engine
This is Rietveld 408576698