Fix enctype=text/plain implementation

Fix enctype=text/plain implementation

Append CRLF after each data entry instead of only in between pairs.

R=tkent@chromium.org,jochen@chromium.org
BUG=687072
Review-Url: https://codereview.chromium.org/2687863002
Cr-Commit-Position: refs/heads/master@{#449608}
Committed: https://chromium.googlesource.com/chromium/src/+/76c9186c1e4d27ef4fb9a3abe72502f5a7b4eb2b

[rongjie, 2017-02-09 12:09:21]

The CQ bit was checked by loorongjie@gmail.com

[rongjie, 2017-02-09 12:09:21]

The CQ bit was unchecked by loorongjie@gmail.com

[rongjie, 2017-02-09 12:39:52]

The CQ bit was checked by loorongjie@gmail.com

[rongjie, 2017-02-09 12:40:00]

The CQ bit was unchecked by loorongjie@gmail.com

[commit-bot: I haz the power, 2017-02-09 12:40:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 12:40:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 12:40:03]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[tkent, 2017-02-09 12:55:55]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 12:56:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2017-02-09 13:13:38]

hey, thx for contributing a patch.

could you please make sure to add a test for this?

[rongjie, 2017-02-09 13:24:13]

On 2017/02/09 13:13:38, jochen wrote:
> hey, thx for contributing a patch.
> 
> could you please make sure to add a test for this?

Should I add test in new file FormDataEncoderTest.cpp or just add it in
third_party/WebKit/Source/platform/network/EncodedFormDataTest.cpp ?

[jochen (gone - plz use gerrit), 2017-02-09 13:29:34]

both options are fine

[tkent, 2017-02-09 20:59:19]

https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...
The following existing tests fail with this patch:

external/wpt/html/semantics/forms/form-submission-0/submit-entity-body.html
fast/forms/mailto/formenctype-attribute-button-html.html
fast/forms/mailto/formenctype-attribute-input-2.html
fast/forms/mailto/formenctype-attribute-input-html.html
fast/forms/mailto/post-multiple-items-text-plain.html
fast/forms/mailto/post-text-plain-with-accept-charset.html
fast/forms/mailto/post-text-plain.html
  We need to update corresponding -expected.txt.

http/tests/misc/form-post-textplain.html
  I think the test needs to be updated.

[rongjie, 2017-02-10 09:10:29]

Patchset #3 (id:40001) has been deleted

[rongjie, 2017-02-10 09:19:41]

I have updated failing tests, can I get another tryjob?

[tkent, 2017-02-10 09:21:45]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 09:22:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 11:05:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 11:05:57]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[rongjie, 2017-02-10 11:20:10]

This patch fixes the last failing test: post-text-plain.html

[tkent, 2017-02-10 12:10:42]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 12:10:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2017-02-10 12:24:55]

why did you drop the newly added test from the CL again?

[rongjie, 2017-02-10 12:32:28]

I just thought that test is no longer useful as .html tests already cover the
same thing.
If you think it is still useful, I will add it back immediately.

(I forgot to add the file to BUILD.gn in patch 2).

[jochen (gone - plz use gerrit), 2017-02-10 13:03:44]

fair enough, lgtm

[commit-bot: I haz the power, 2017-02-10 13:47:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 13:48:00]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-02-10 13:57:28]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-02-10 13:57:29]

lgtm

[commit-bot: I haz the power, 2017-02-10 13:57:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 14:01:54]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486735048439150,
"parent_rev": "937fd873bf0791a2b402a7c32a7b29749656fec8", "commit_rev":
"76c9186c1e4d27ef4fb9a3abe72502f5a7b4eb2b"}

[commit-bot: I haz the power, 2017-02-10 14:02:55]

Description was changed from

==========
Fix enctype=text/plain implementation

Append CRLF after each data entry instead of only in between pairs.

R=tkent@chromium.org,jochen@chromium.org
BUG=687072
==========

to

==========
Fix enctype=text/plain implementation

Append CRLF after each data entry instead of only in between pairs.

R=tkent@chromium.org,jochen@chromium.org
BUG=687072

Review-Url: https://codereview.chromium.org/2687863002
Cr-Commit-Position: refs/heads/master@{#449608}
Committed:
https://chromium.googlesource.com/chromium/src/+/76c9186c1e4d27ef4fb9a3abe725...
==========

[commit-bot: I haz the power, 2017-02-10 14:02:56]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/76c9186c1e4d27ef4fb9a3abe725...