Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2687833002: Remove prepareForThreadStateTermination() (Closed)

Created:
3 years, 10 months ago by haraken
Modified:
3 years, 10 months ago
Reviewers:
sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), haraken, blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove prepareForThreadStateTermination() Now that we don't have a thread-local termination GC, we don't need to mark pages in other threads' heaps as isTerminating. This removes that code. BUG=671856 Review-Url: https://codereview.chromium.org/2687833002 Cr-Commit-Position: refs/heads/master@{#449253} Committed: https://chromium.googlesource.com/chromium/src/+/056cbe3263229baa0402d969de8bf5350c3bdf36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -36 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapPage.h View 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 3 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
haraken
PTAL
3 years, 10 months ago (2017-02-09 08:16:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687833002/1
3 years, 10 months ago (2017-02-09 08:18:35 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-09 08:18:37 UTC) #7
sof
lgtm
3 years, 10 months ago (2017-02-09 08:27:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687833002/1
3 years, 10 months ago (2017-02-09 08:32:38 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 10:16:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/056cbe3263229baa0402d969de8b...

Powered by Google App Engine
This is Rietveld 408576698