Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2687753002: Revert MenuController Checks (Closed)

Created:
3 years, 10 months ago by jonross
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert MenuController Checks Revert "New MenuController Checks" This reverts commit 07c6e27a5cea714d7fdfbb297b998a531eb45371. BUG=683087 Review-Url: https://codereview.chromium.org/2687753002 Cr-Commit-Position: refs/heads/master@{#449167} Committed: https://chromium.googlesource.com/chromium/src/+/4fc4ce03ef87775b0d392d07aa69323e37f82b55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -53 lines) Patch
M ui/views/controls/menu/menu_controller.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 8 chunks +0 lines, -30 lines 0 comments Download
M ui/views/controls/menu/menu_runner_impl.cc View 4 chunks +3 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jonross
Hey Sky@, This change reverts checks I added to test possible causes of a use-after-free. ...
3 years, 10 months ago (2017-02-08 23:06:29 UTC) #2
sky
LGTM
3 years, 10 months ago (2017-02-08 23:57:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687753002/1
3 years, 10 months ago (2017-02-08 23:59:25 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 00:57:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4fc4ce03ef87775b0d392d07aa69...

Powered by Google App Engine
This is Rietveld 408576698