Linux/Windows: Setting focus to the first profile in profile switcher

Linux/Windows: Setting focus to the first profile in profile switcher

When opening the profile switcher menu using the shortcut (ctrl-shift-m), the first
profile (other than the current one) in the list should be highlighted. This should
happens only when opening the menu with the keyboard (and not with the mouse).

For macOS: crrev.com/2638853003 and crrev.com/2682153002

BUG=674343
Review-Url: https://codereview.chromium.org/2687693002
Cr-Commit-Position: refs/heads/master@{#452449}
Committed: https://chromium.googlesource.com/chromium/src/+/233d5951645e51d856784682bd5c1b32b2f60f81

[jlebel, 2017-02-08 15:22:38]

Patchset #1 (id:1) has been deleted

[jlebel, 2017-02-08 17:09:08]

The CQ bit was checked by jlebel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 17:09:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jlebel, 2017-02-08 17:09:56]

Description was changed from

==========
Linux/Windows: Setting focus to the first profile in profile switcher

When opening the profile switcher menu using the shortcut (ctrl-shift-m), the
first
profile (other than the current one) in the list should be highlighted. This
should
happens only when opening the menu with the keyboard (and not with the mouse).

For macOS: crrev.com/2638853003

BUG=674343
==========

to

==========
Linux/Windows: Setting focus to the first profile in profile switcher

When opening the profile switcher menu using the shortcut (ctrl-shift-m), the
first
profile (other than the current one) in the list should be highlighted. This
should
happens only when opening the menu with the keyboard (and not with the mouse).

For macOS: crrev.com/2638853003 and crrev.com/2682153002

BUG=674343
==========

[commit-bot: I haz the power, 2017-02-08 18:48:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 18:48:45]

Dry run: This issue passed the CQ dry run.

[jlebel, 2017-02-09 12:55:05]

jlebel@chromium.org changed reviewers:
+ sky@chromium.org

[jlebel, 2017-02-09 12:55:06]

Hello sky

Can you review my patch about the profile switching menu? This is about getting
focus on the first profile (other than the current profile) while opening with
the keyboard. The point is to help the user to switch faster between profiles.

Thanks,

Jérôme,

[sky, 2017-02-09 19:22:14]

On 2017/02/09 12:55:06, jlebel wrote:
> Hello sky
> 
> Can you review my patch about the profile switching menu? This is about
getting
> focus on the first profile (other than the current profile) while opening with
> the keyboard. The point is to help the user to switch faster between profiles.
> 
> Thanks,
> 
> Jérôme,

I'll take a look shortly, but one question. Why do you differentiate between
opening via keyboard vs mouse? Why not focus all the time?

[jlebel, 2017-02-09 19:43:25]

On 2017/02/09 19:22:14, sky wrote:
> On 2017/02/09 12:55:06, jlebel wrote:
> > Hello sky
> > 
> > Can you review my patch about the profile switching menu? This is about
> getting
> > focus on the first profile (other than the current profile) while opening
with
> > the keyboard. The point is to help the user to switch faster between
profiles.
> > 
> > Thanks,
> > 
> > Jérôme,
> 
> I'll take a look shortly, but one question. Why do you differentiate between
> opening via keyboard vs mouse? Why not focus all the time?

There is the keyboard focus and the mouse highlight on Windows/Linux. The goal
is to show the keyboard focus on the next profile, so the user can just press
enter if he has 2 profiles while using the keyboard to open the menu. If he uses
the mouse, there is no point to show the keyboard focus since he uses the mouse.
That's the idea for this patch.
Thanks for your time!

[sky, 2017-02-09 20:05:00]

On 2017/02/09 19:43:25, jlebel wrote:
> On 2017/02/09 19:22:14, sky wrote:
> > On 2017/02/09 12:55:06, jlebel wrote:
> > > Hello sky
> > > 
> > > Can you review my patch about the profile switching menu? This is about
> > getting
> > > focus on the first profile (other than the current profile) while opening
> with
> > > the keyboard. The point is to help the user to switch faster between
> profiles.
> > > 
> > > Thanks,
> > > 
> > > Jérôme,
> > 
> > I'll take a look shortly, but one question. Why do you differentiate between
> > opening via keyboard vs mouse? Why not focus all the time?
> 
> There is the keyboard focus and the mouse highlight on Windows/Linux. The goal
> is to show the keyboard focus on the next profile, so the user can just press
> enter if he has 2 profiles while using the keyboard to open the menu. If he
uses
> the mouse, there is no point to show the keyboard focus since he uses the
mouse.
> That's the idea for this patch.
> Thanks for your time!

Why is there no point in assigning focus if the mouse was initially used? Taking
your argument to the extreme would imply when the user uses a mouse to bring up
a window we shouldn't assign keyboard focus. I'm not aware of other situations
like this. Generally when a window is activated we assign focus.

[sky, 2017-02-09 20:17:39]

https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_commands.cc (right):

https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/brows...
chrome/browser/ui/browser_commands.cc:1131: void ShowFastUserSwitcher(Browser*
browser) {
Is this called anywhere?

https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:776: if
(focus_first_profile_button) {
no {}

https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:776: if
(focus_first_profile_button) {
It seems unnecessary to store this view. Can't you extract it when necessary? Or
better yet when building the ui track what is the first button to focus?

https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:1012: if
(first_profile_button_) {
no {}

https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:1039: return
signin_current_profile_button_;
You should return the view here.

https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:1916: if
(switches::IsMaterialDesignUserMenu()) {
What about the !md case?

[jlebel, 2017-02-10 12:13:43]

jlebel@chromium.org changed reviewers:
+ anthonyvd@chromium.org

[jlebel, 2017-02-10 12:13:43]

Hello anthony,

Can you tell if ShowFastUserSwitcher() in browser_commands.cc is still used?

Thanks,

https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_commands.cc (right):

https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/brows...
chrome/browser/ui/browser_commands.cc:1131: void ShowFastUserSwitcher(Browser*
browser) {
@anthonyvd Do you think this is still used?

Should I remove this code in a next patch if it is not used anymore?

https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:776: if
(focus_first_profile_button) {
On 2017/02/09 20:17:39, sky wrote:
> It seems unnecessary to store this view. Can't you extract it when necessary?
Or
> better yet when building the ui track what is the first button to focus?

There are different buttons in this menu. The beginning is not always the same.
I'm not sure how to get the first profile in the list.

https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:1012: if
(first_profile_button_) {
On 2017/02/09 20:17:39, sky wrote:
> no {}

Done.

[sky, 2017-02-10 18:55:59]

On 2017/02/09 20:05:00, sky wrote:
> On 2017/02/09 19:43:25, jlebel wrote:
> > On 2017/02/09 19:22:14, sky wrote:
> > > On 2017/02/09 12:55:06, jlebel wrote:
> > > > Hello sky
> > > > 
> > > > Can you review my patch about the profile switching menu? This is about
> > > getting
> > > > focus on the first profile (other than the current profile) while
opening
> > with
> > > > the keyboard. The point is to help the user to switch faster between
> > profiles.
> > > > 
> > > > Thanks,
> > > > 
> > > > Jérôme,
> > > 
> > > I'll take a look shortly, but one question. Why do you differentiate
between
> > > opening via keyboard vs mouse? Why not focus all the time?
> > 
> > There is the keyboard focus and the mouse highlight on Windows/Linux. The
goal
> > is to show the keyboard focus on the next profile, so the user can just
press
> > enter if he has 2 profiles while using the keyboard to open the menu. If he
> uses
> > the mouse, there is no point to show the keyboard focus since he uses the
> mouse.
> > That's the idea for this patch.
> > Thanks for your time!
> 
> Why is there no point in assigning focus if the mouse was initially used?
Taking
> your argument to the extreme would imply when the user uses a mouse to bring
up
> a window we shouldn't assign keyboard focus. I'm not aware of other situations
> like this. Generally when a window is activated we assign focus.

I would still like an answer to this question. I don't understand the design not
to always focus.

[jlebel, 2017-02-13 09:58:06]

On 2017/02/10 18:55:59, sky wrote:
> On 2017/02/09 20:05:00, sky wrote:
> > On 2017/02/09 19:43:25, jlebel wrote:
> > > On 2017/02/09 19:22:14, sky wrote:
> > > > On 2017/02/09 12:55:06, jlebel wrote:
> > > > > Hello sky
> > > > > 
> > > > > Can you review my patch about the profile switching menu? This is
about
> > > > getting
> > > > > focus on the first profile (other than the current profile) while
> opening
> > > with
> > > > > the keyboard. The point is to help the user to switch faster between
> > > profiles.
> > > > > 
> > > > > Thanks,
> > > > > 
> > > > > Jérôme,
> > > > 
> > > > I'll take a look shortly, but one question. Why do you differentiate
> between
> > > > opening via keyboard vs mouse? Why not focus all the time?
> > > 
> > > There is the keyboard focus and the mouse highlight on Windows/Linux. The
> goal
> > > is to show the keyboard focus on the next profile, so the user can just
> press
> > > enter if he has 2 profiles while using the keyboard to open the menu. If
he
> > uses
> > > the mouse, there is no point to show the keyboard focus since he uses the
> > mouse.
> > > That's the idea for this patch.
> > > Thanks for your time!
> > 
> > Why is there no point in assigning focus if the mouse was initially used?
> Taking
> > your argument to the extreme would imply when the user uses a mouse to bring
> up
> > a window we shouldn't assign keyboard focus. I'm not aware of other
situations
> > like this. Generally when a window is activated we assign focus.
> 
> I would still like an answer to this question. I don't understand the design
not
> to always focus.

Sorry about that. My PM asks me to do that. And I guess his idea is in a menu
the first item is not supposed to have the keyboard focus in general. But if the
user
opens it with the keyboard it will make his life easier to select the next
profile since
he will not have to press twice the down arrow to get to the next profile.
But if the user uses the mouse, there is no point of doing this keyboard focus.

[anthonyvd, 2017-02-13 15:46:46]

https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_commands.cc (right):

https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/brows...
chrome/browser/ui/browser_commands.cc:1131: void ShowFastUserSwitcher(Browser*
browser) {
On 2017/02/10 at 12:13:43, jlebel wrote:
> @anthonyvd Do you think this is still used?
> 
> Should I remove this code in a next patch if it is not used anymore?

It's potentially called in one place, although it shouldn't be since we removed
the fast user switcher. I think it's still in the code because there was a
transition period where we wanted to show the full avatar menu when people tried
to use the fast user switcher.

You should ask ewald@ if it's now fine to remove the right-clickability of the
avatar button. If it is, you can safely remove this function and clean up
IDC_SHOW_FAST_USER_SWITCHER and whatever's around it.

[sky, 2017-02-13 18:05:31]

Can you attach screenshots of what this looks like with and without the focus?

On Mon, Feb 13, 2017 at 7:46 AM,  <anthonyvd@chromium.org> wrote:
>
>
https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/brows...
> File chrome/browser/ui/browser_commands.cc (right):
>
>
https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/brows...
> chrome/browser/ui/browser_commands.cc:1131: void
> ShowFastUserSwitcher(Browser* browser) {
> On 2017/02/10 at 12:13:43, jlebel wrote:
>> @anthonyvd Do you think this is still used?
>>
>> Should I remove this code in a next patch if it is not used anymore?
>
> It's potentially called in one place, although it shouldn't be since we
> removed the fast user switcher. I think it's still in the code because
> there was a transition period where we wanted to show the full avatar
> menu when people tried to use the fast user switcher.
>
> You should ask ewald@ if it's now fine to remove the right-clickability
> of the avatar button. If it is, you can safely remove this function and
> clean up IDC_SHOW_FAST_USER_SWITCHER and whatever's around it.
>
> https://codereview.chromium.org/2687693002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jlebel, 2017-02-14 10:53:43]

On 2017/02/13 18:05:31, sky wrote:
> Can you attach screenshots of what this looks like with and without the focus?
> 
> On Mon, Feb 13, 2017 at 7:46 AM,  <mailto:anthonyvd@chromium.org> wrote:
> >
> >
>
https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/brows...
> > File chrome/browser/ui/browser_commands.cc (right):
> >
> >
>
https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/brows...
> > chrome/browser/ui/browser_commands.cc:1131: void
> > ShowFastUserSwitcher(Browser* browser) {
> > On 2017/02/10 at 12:13:43, jlebel wrote:
> >> @anthonyvd Do you think this is still used?
> >>
> >> Should I remove this code in a next patch if it is not used anymore?
> >
> > It's potentially called in one place, although it shouldn't be since we
> > removed the fast user switcher. I think it's still in the code because
> > there was a transition period where we wanted to show the full avatar
> > menu when people tried to use the fast user switcher.
> >
> > You should ask ewald@ if it's now fine to remove the right-clickability
> > of the avatar button. If it is, you can safely remove this function and
> > clean up IDC_SHOW_FAST_USER_SWITCHER and whatever's around it.
> >
> > https://codereview.chromium.org/2687693002/
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.
> 

Here is an example on Linux with the dotted line around my Google profile:
https://screenshot.googleplex.com/sLKsrYt23H9

[sky, 2017-02-14 18:05:20]

Thanks for attaching the screenshot.

https://codereview.chromium.org/2687693002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/2687693002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:748: bool
focus_first_profile_button) {
I think this is really whether a keyboard was used to show the bubble. Can you
rename the variable here and other places to indicate that, say
is_source_keyboard?

https://codereview.chromium.org/2687693002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:1930: if
(!first_profile_button_) {
no {}

[jlebel, 2017-02-20 15:25:35]

The CQ bit was checked by jlebel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 15:25:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jlebel, 2017-02-20 16:11:23]

https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_commands.cc (right):

https://codereview.chromium.org/2687693002/diff/20001/chrome/browser/ui/brows...
chrome/browser/ui/browser_commands.cc:1131: void ShowFastUserSwitcher(Browser*
browser) {
On 2017/02/13 15:46:45, anthonyvd wrote:
> On 2017/02/10 at 12:13:43, jlebel wrote:
> > @anthonyvd Do you think this is still used?
> > 
> > Should I remove this code in a next patch if it is not used anymore?
> 
> It's potentially called in one place, although it shouldn't be since we
removed
> the fast user switcher. I think it's still in the code because there was a
> transition period where we wanted to show the full avatar menu when people
tried
> to use the fast user switcher.
> 
> You should ask ewald@ if it's now fine to remove the right-clickability of the
> avatar button. If it is, you can safely remove this function and clean up
> IDC_SHOW_FAST_USER_SWITCHER and whatever's around it.

I talked offline with ewald@, this feature is not used anymore. I created:
crbug.com/694285

https://codereview.chromium.org/2687693002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/2687693002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:748: bool
focus_first_profile_button) {
On 2017/02/14 18:05:20, sky wrote:
> I think this is really whether a keyboard was used to show the bubble. Can you
> rename the variable here and other places to indicate that, say
> is_source_keyboard?

Done.

https://codereview.chromium.org/2687693002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:1930: if
(!first_profile_button_) {
On 2017/02/14 18:05:20, sky wrote:
> no {}

Done.

[commit-bot: I haz the power, 2017-02-20 16:14:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 16:14:35]

Dry run: This issue passed the CQ dry run.

[sky, 2017-02-21 17:57:55]

LGTM

[jlebel, 2017-02-21 21:52:17]

The CQ bit was checked by jlebel@chromium.org

[commit-bot: I haz the power, 2017-02-21 21:54:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 23:58:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 23:58:19]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[jlebel, 2017-02-22 00:03:08]

The CQ bit was checked by jlebel@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:05:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 02:08:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 02:08:57]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[jlebel, 2017-02-22 06:55:57]

jlebel@chromium.org changed reviewers:
+ bauerb@chromium.org

[jlebel, 2017-02-22 06:55:58]

Hello Bernhard,

Can you review this patch?

Thanks,

[Bernhard Bauer, 2017-02-22 15:27:26]

Web UI LGTM (I assume that's what you want me to review).

[jlebel, 2017-02-22 16:14:31]

The CQ bit was checked by jlebel@chromium.org

[commit-bot: I haz the power, 2017-02-22 16:14:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 16:22:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 16:22:06]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jlebel, 2017-02-22 17:22:27]

jlebel@chromium.org changed reviewers:
+ tsergeant@chromium.org

[jlebel, 2017-02-22 17:22:28]

Hello tsergeant,

Can you review chrome/browser/ui/webui/history_login_handler.cc in this patch?

Thanks,

[jlebel, 2017-02-22 17:23:14]

jlebel@chromium.org changed reviewers:
+ atwilson@chromium.org

[jlebel, 2017-02-22 17:23:15]

Hello Andrew,

Can you review chrome/browser/ui/webui/options/sync_setup_handler.cc  in this
patch?

Thanks,

[tsergeant, 2017-02-22 21:32:46]

history_login_handler lgtm

[Andrew T Wilson (Slow), 2017-02-23 10:15:36]

lgtm

[jlebel, 2017-02-23 10:16:01]

The CQ bit was checked by jlebel@chromium.org

[commit-bot: I haz the power, 2017-02-23 10:16:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 10:55:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487844961879360,
"parent_rev": "6d58fe57ab739bbc26291e04bce804721ba5b93d", "commit_rev":
"233d5951645e51d856784682bd5c1b32b2f60f81"}

[commit-bot: I haz the power, 2017-02-23 10:56:21]

Description was changed from

==========
Linux/Windows: Setting focus to the first profile in profile switcher

When opening the profile switcher menu using the shortcut (ctrl-shift-m), the
first
profile (other than the current one) in the list should be highlighted. This
should
happens only when opening the menu with the keyboard (and not with the mouse).

For macOS: crrev.com/2638853003 and crrev.com/2682153002

BUG=674343
==========

to

==========
Linux/Windows: Setting focus to the first profile in profile switcher

When opening the profile switcher menu using the shortcut (ctrl-shift-m), the
first
profile (other than the current one) in the list should be highlighted. This
should
happens only when opening the menu with the keyboard (and not with the mouse).

For macOS: crrev.com/2638853003 and crrev.com/2682153002

BUG=674343

Review-Url: https://codereview.chromium.org/2687693002
Cr-Commit-Position: refs/heads/master@{#452449}
Committed:
https://chromium.googlesource.com/chromium/src/+/233d5951645e51d856784682bd5c...
==========

[commit-bot: I haz the power, 2017-02-23 10:56:23]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/233d5951645e51d856784682bd5c...