Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2687683006: Don't initialize V8 in the GPU process. (Closed)

Created:
3 years, 10 months ago by Jay Civelli
Modified:
3 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't initialize V8 in the GPU process. Don't initialize V8 in the GPU process, V8 should not be used there. BUG=690200 Review-Url: https://codereview.chromium.org/2687683006 Cr-Commit-Position: refs/heads/master@{#449348} Committed: https://chromium.googlesource.com/chromium/src/+/15ffa4689839fa575de38a25c89780450b83e9d0

Patch Set 1 #

Patch Set 2 : Clean up. #

Patch Set 3 : Fix compilation on Android and Win. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -48 lines) Patch
M content/app/content_main_runner.cc View 1 2 4 chunks +58 lines, -48 lines 0 comments Download

Messages

Total messages: 17 (14 generated)
jochen (gone - plz use gerrit)
lgtm once it compiles
3 years, 10 months ago (2017-02-09 08:18:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687683006/40001
3 years, 10 months ago (2017-02-09 17:57:11 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 18:03:15 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/15ffa4689839fa575de38a25c897...

Powered by Google App Engine
This is Rietveld 408576698