Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2687683005: DevTools: rebaseline tests for backwards compatibility (Closed)

Created:
3 years, 10 months ago by chenwilliam
Modified:
3 years, 10 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, devtools-reviews_chromium.org, extensions-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: rebaseline tests for backwards compatibility BUG=682078 Review-Url: https://codereview.chromium.org/2687683005 Cr-Commit-Position: refs/heads/master@{#449090} Committed: https://chromium.googlesource.com/chromium/src/+/903b3929e9ea7f4403bea67d27ff954707549006

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -189 lines) Patch
M third_party/WebKit/Source/devtools/tests/TestExpectations View 2 chunks +18 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/http/tests/inspector/network/x-frame-options-deny-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/http/tests/inspector/persistence/persistence-move-breakpoints-on-reload-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/http/tests/inspector/search/sources-search-scope-in-files-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/http/tests/inspector/sources/debugger/async-callstack-network-initiator-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/http/tests/inspector/sources/ui-source-code-metadata-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector-protocol/layout-fonts/generic-system-ui-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector-protocol/runtime/runtime-await-promise-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-edit-property-value-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-format-es6-expected.txt View 2 chunks +35 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-format-expected.txt View 16 chunks +81 lines, -77 lines 0 comments Download
M third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-log-object-with-getter-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/console/console-object-preview-expected.txt View 1 chunk +36 lines, -36 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/extensions/extensions-eval-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/extensions/extensions-sidebar-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/input-event-warning-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/layers/layer-replay-scale-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/layers/layer-tree-model-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/report-protocol-errors-expected.txt View 5 chunks +11 lines, -8 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/schema-get-domains-matches-agents-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/screen-orientation-override-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
chenwilliam
Please take a look. Almost done rebaselining all the tests and then I can add ...
3 years, 10 months ago (2017-02-08 18:51:59 UTC) #2
pfeldman
lgtm
3 years, 10 months ago (2017-02-08 19:13:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687683005/1
3 years, 10 months ago (2017-02-08 19:58:30 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 21:13:24 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/903b3929e9ea7f4403bea67d27ff...

Powered by Google App Engine
This is Rietveld 408576698