Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2687683004: exo: Do not call UpdateShelfStateForFullscreenChange() in ShellSurface (Closed)

Created:
3 years, 10 months ago by Peng
Modified:
3 years, 10 months ago
Reviewers:
reveman, oshima
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Do not call UpdateShelfStateForFullscreenChange() in ShellSurface ash::WorkspaceLayoutManager::OnPostWindowStateTypeChange() will call UpdateShelfVisibility() to update shelf visibility for window state changes for every window. So we don't need update shell visibility for exo Window anymore. BUG=670496 Review-Url: https://codereview.chromium.org/2687683004 Cr-Commit-Position: refs/heads/master@{#449110} Committed: https://chromium.googlesource.com/chromium/src/+/ce3f7a721ca8dabb1b13ba506d9980d60c5e02ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M components/exo/shell_surface.cc View 3 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Peng
Hi Oshima, PTAL. Thanks.
3 years, 10 months ago (2017-02-08 18:19:12 UTC) #4
oshima
non owner lgtm I think you should also remove this as well. https://cs.chromium.org/chromium/src/ash/common/wm/immersive_context_ash.cc?rcl=f2d23ac6b62b2e0560bd756bc22e4ab0d66fe8eb&l=39
3 years, 10 months ago (2017-02-08 18:33:41 UTC) #5
Peng
On 2017/02/08 18:33:41, oshima wrote: > non owner lgtm > > I think you should ...
3 years, 10 months ago (2017-02-08 18:36:21 UTC) #6
Peng
Hi David, PTAL. Thanks.
3 years, 10 months ago (2017-02-08 18:36:56 UTC) #8
reveman
lgtm
3 years, 10 months ago (2017-02-08 21:58:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687683004/1
3 years, 10 months ago (2017-02-08 22:23:38 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 22:31:11 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ce3f7a721ca8dabb1b13ba506d99...

Powered by Google App Engine
This is Rietveld 408576698