Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1799)

Unified Diff: chrome/browser/local_discovery/service_discovery_shared_client.cc

Issue 268763006: Disable firewall check. It takes signifficant time, need to be on FILE thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/local_discovery/service_discovery_shared_client.cc
diff --git a/chrome/browser/local_discovery/service_discovery_shared_client.cc b/chrome/browser/local_discovery/service_discovery_shared_client.cc
index dcfb64b93e8322c5737498862f83e6aeaa9fcd0a..8c9455a4cb4ea7b0cfd532f04f817e0f94aa1071 100644
--- a/chrome/browser/local_discovery/service_discovery_shared_client.cc
+++ b/chrome/browser/local_discovery/service_discovery_shared_client.cc
@@ -28,6 +28,8 @@ namespace {
#if defined(OS_WIN)
bool IsFirewallReady() {
+ // TODO(vitalybuka): move to FILE thread, firewall access time is substantial.
+ return false.
Noam Samuel 2014/05/02 21:43:16 A bit more work/pain, but maybe it makes sense to
base::FilePath exe_path;
if (!PathService::Get(base::FILE_EXE, &exe_path))
return false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698