Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: chrome/browser/local_discovery/service_discovery_shared_client.cc

Issue 268763006: Disable firewall check. It takes signifficant time, need to be on FILE thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/local_discovery/service_discovery_shared_client.h" 5 #include "chrome/browser/local_discovery/service_discovery_shared_client.h"
6 6
7 #include "content/public/browser/browser_thread.h" 7 #include "content/public/browser/browser_thread.h"
8 8
9 #if defined(OS_WIN) 9 #if defined(OS_WIN)
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 10 matching lines...) Expand all
21 #endif 21 #endif
22 22
23 #if defined(ENABLE_MDNS) 23 #if defined(ENABLE_MDNS)
24 #include "chrome/browser/local_discovery/service_discovery_client_mdns.h" 24 #include "chrome/browser/local_discovery/service_discovery_client_mdns.h"
25 #endif // ENABLE_MDNS 25 #endif // ENABLE_MDNS
26 26
27 namespace { 27 namespace {
28 28
29 #if defined(OS_WIN) 29 #if defined(OS_WIN)
30 bool IsFirewallReady() { 30 bool IsFirewallReady() {
31 // TODO(vitalybuka): move to FILE thread, firewall access time is substantial.
32 return false.
Noam Samuel 2014/05/02 21:43:16 A bit more work/pain, but maybe it makes sense to
31 base::FilePath exe_path; 33 base::FilePath exe_path;
32 if (!PathService::Get(base::FILE_EXE, &exe_path)) 34 if (!PathService::Get(base::FILE_EXE, &exe_path))
33 return false; 35 return false;
34 base::ElapsedTimer timer; 36 base::ElapsedTimer timer;
35 scoped_ptr<installer::FirewallManager> manager = 37 scoped_ptr<installer::FirewallManager> manager =
36 installer::FirewallManager::Create(BrowserDistribution::GetDistribution(), 38 installer::FirewallManager::Create(BrowserDistribution::GetDistribution(),
37 exe_path); 39 exe_path);
38 if (!manager) 40 if (!manager)
39 return false; 41 return false;
40 bool is_ready = manager->CanUseLocalPorts(); 42 bool is_ready = manager->CanUseLocalPorts();
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 scoped_refptr<ServiceDiscoverySharedClient> 97 scoped_refptr<ServiceDiscoverySharedClient>
96 ServiceDiscoverySharedClient::GetInstance() { 98 ServiceDiscoverySharedClient::GetInstance() {
97 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 99 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
98 NOTIMPLEMENTED(); 100 NOTIMPLEMENTED();
99 return NULL; 101 return NULL;
100 } 102 }
101 103
102 #endif // ENABLE_MDNS 104 #endif // ENABLE_MDNS
103 105
104 } // namespace local_discovery 106 } // namespace local_discovery
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698