Issue 268763006: Disable firewall check. It takes signifficant time, need to be on FILE thread.

Issue 268763006: Disable firewall check. It takes signifficant time, need to be on FILE thread. (Closed)

Created:
6 years, 7 months ago by Vitaly Buka (NO REVIEWS)

Modified:
6 years, 7 months ago

Reviewers:
Noam Samuel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable firewall check. It takes signifficant time, need to be on FILE thread. TBR=noamsml Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268036

Patch Set 2 : Fri 05/02/2014 16:39:31.63 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -10 lines)			Patch
	M	chrome/browser/local_discovery/service_discovery_shared_client.cc	View	1	2 chunks	+9 lines, -10 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Noam Samuel

https://codereview.chromium.org/268763006/diff/1/chrome/browser/local_discovery/service_discovery_shared_client.cc File chrome/browser/local_discovery/service_discovery_shared_client.cc (right): https://codereview.chromium.org/268763006/diff/1/chrome/browser/local_discovery/service_discovery_shared_client.cc#newcode32 chrome/browser/local_discovery/service_discovery_shared_client.cc:32: return false. A bit more work/pain, but maybe it ...

6 years, 7 months ago (2014-05-02 21:43:16 UTC) #2

Vitaly Buka (NO REVIEWS)

The CQ bit was checked by vitalybuka@chromium.org

6 years, 7 months ago (2014-05-03 01:03:56 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/268763006/20001

6 years, 7 months ago (2014-05-03 01:04:18 UTC) #5

Noam Samuel

6 years, 7 months ago (2014-05-05 17:18:53 UTC) #7

Message was sent while issue was closed.

On 2014/05/03 04:13:41, I haz the power (commit-bot) wrote:
> Change committed as 268036

lgtm

Expand Messages | Collapse Messages