DevTools: Support breakpoints on canvas context creation

DevTools: Support breakpoints on canvas context creation

BUG=689782
Review-Url: https://codereview.chromium.org/2687623002
Cr-Commit-Position: refs/heads/master@{#448904}
Committed: https://chromium.googlesource.com/chromium/src/+/3abea62a6cf6a2e0ca7e1026923f0cd0f5e45b3c

[pfeldman, 2017-02-08 02:44:27]

pfeldman@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2017-02-08 02:47:38]

lgtm

[caseq, 2017-02-08 02:47:40]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2017-02-08 02:48:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2017-02-08 02:58:37]

Description was changed from

==========
DevTools: Support breakpoints on canvas context creation

BUG=689782
==========

to

==========
DevTools: Support breakpoints on canvas context creation

BUG=689782
==========

[pfeldman, 2017-02-08 02:58:37]

pfeldman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[kozy, 2017-02-08 04:21:25]

lgtm

[commit-bot: I haz the power, 2017-02-08 04:36:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486522060801650, "parent_rev":
"db69128064ff7433c7243e4387294b70dc052de1", "commit_rev":
"3abea62a6cf6a2e0ca7e1026923f0cd0f5e45b3c"}

[commit-bot: I haz the power, 2017-02-08 04:37:14]

Description was changed from

==========
DevTools: Support breakpoints on canvas context creation

BUG=689782
==========

to

==========
DevTools: Support breakpoints on canvas context creation

BUG=689782

Review-Url: https://codereview.chromium.org/2687623002
Cr-Commit-Position: refs/heads/master@{#448904}
Committed:
https://chromium.googlesource.com/chromium/src/+/3abea62a6cf6a2e0ca7e1026923f...
==========

[commit-bot: I haz the power, 2017-02-08 04:37:16]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3abea62a6cf6a2e0ca7e1026923f...

[Justin Novosad, 2017-02-09 20:23:02]

junov@chromium.org changed reviewers:
+ junov@chromium.org

[Justin Novosad, 2017-02-09 20:23:03]

https://codereview.chromium.org/2687623002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (right):

https://codereview.chromium.org/2687623002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:275:
InspectorInstrumentation::didCreateCanvasContext(&document());
You need to do the same thing in OffscreenCanvas::getCanvasRenderingContext

[pfeldman, 2017-02-09 21:01:47]

> You need to do the same thing in OffscreenCanvas::getCanvasRenderingContext

I don't think I _need_ to :). Workers don't have dom debugger to report it
through, so we'd need to introduce a better API on the v8_inspector side or an
entity in blink that would manage native breakpoints. Feel free to file a bug!

[Justin Novosad, 2017-02-16 16:53:01]

On 2017/02/09 21:01:47, pfeldman wrote:
> > You need to do the same thing in OffscreenCanvas::getCanvasRenderingContext
> 
> I don't think I _need_ to :). Workers don't have dom debugger to report it
> through, so we'd need to introduce a better API on the v8_inspector side or an
> entity in blink that would manage native breakpoints. Feel free to file a bug!

I see. FYI, OffscreenCanvas is also exposed on the main thread, not just
workers.

[pfeldman, 2017-02-16 18:43:58]

> I see. FYI, OffscreenCanvas is also exposed on the main thread, not just
> workers.

would it make sense calling isDocument() on execution context and only doing it
for document-side ones? that one is cheap.

[Justin Novosad, 2017-02-16 18:50:06]

On 2017/02/16 18:43:58, pfeldman wrote:
> > I see. FYI, OffscreenCanvas is also exposed on the main thread, not just
> > workers.
> 
> would it make sense calling isDocument() on execution context and only doing
it
> for document-side ones? that one is cheap.

I think so.