PlzNavigate: Invoke didFailProvisionalLoad() in the renderer when a navigation request is cancelled…

content/browser/frame_host/navigator_impl.cc

Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index 0c34b760f629ae56c9c4c8fa0b69852949bee897..00cc0be64abf353a817b58c33e4a686f03c5084d 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -1023,16 +1023,19 @@ void NavigatorImpl::FailedNavigation(FrameTreeNode* frame_tree_node,
   if (!IsRendererDebugURL(navigation_request->navigation_handle()->GetURL()))
     DiscardPendingEntryIfNeeded(navigation_request->navigation_handle());
 
+  // Select an appropriate renderer to show the error page.
+  RenderFrameHostImpl* render_frame_host =
+      frame_tree_node->render_manager()->GetFrameHostForNavigation(
+      *navigation_request);
+
   // If the request was canceled by the user do not show an error page.
   if (error_code == net::ERR_ABORTED) {
+    render_frame_host->AbortNavigationRequest(

[clamy, 2017/02/08 17:13:34]

How many tests fail without this? I'm not terribly fan of adding this. I don't
think we should do an IPC to the renderer to tell it that something was aborted,
especially a browser-initiated navigations.

Instead, would the following work? We send a Stop IPC to the renderer if the
request is renderer-initiated. In the renderer, we have a boolean that records
that the navigation is being handled by the client. Could we fire a
didFailProvisionalLoad with net::ERR_ABORTED when we're told to stop and we
expected the client to be navigating for us?

[ananta, 2017/02/08 23:02:19]

Thanks. FrameLoader::stopAllLoaders() now sends failed provisional load
notifications for client side navigations. 

We still need the provisional load failed notification in
RenderFrameImpl::OnFailedNavigation(). I added a check for doing this only for
renderer initiated navigations. This covers the
http\tests\loading\bad-server-subframe.html layout test

+        navigation_request->common_params().url, error_code);
     frame_tree_node->ResetNavigationRequest(false);
     return;
   }
 
-  // Select an appropriate renderer to show the error page.
-  RenderFrameHostImpl* render_frame_host =
-      frame_tree_node->render_manager()->GetFrameHostForNavigation(
-          *navigation_request);
   CheckWebUIRendererDoesNotDisplayNormalURL(
       render_frame_host, navigation_request->common_params().url);