PlzNavigate: Invoke didFailProvisionalLoad() in the renderer when a navigation request is cancelled…

content/browser/frame_host/navigator_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigator_impl.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 1005 matching lines @@
   NavigationRequest* navigation_request = frame_tree_node->navigation_request();
   DCHECK(navigation_request);
 
   // With PlzNavigate, debug URLs will give a failed navigation because the
   // WebUI backend won't find a handler for them. They will be processed in the
   // renderer, however do not discard the pending entry so that the URL bar
   // shows them correctly.
   if (!IsRendererDebugURL(navigation_request->navigation_handle()->GetURL()))
     DiscardPendingEntryIfNeeded(navigation_request->navigation_handle());
 
+  // Select an appropriate renderer to show the error page.
+  RenderFrameHostImpl* render_frame_host =
+      frame_tree_node->render_manager()->GetFrameHostForNavigation(
+      *navigation_request);
+
   // If the request was canceled by the user do not show an error page.
   if (error_code == net::ERR_ABORTED) {
+    render_frame_host->AbortNavigationRequest(

[clamy, 2017/02/08 17:13:34]

How many tests fail without this? I'm not terribly fan of adding this. I don't
think we should do an IPC to the renderer to tell it that something was aborted,
especially a browser-initiated navigations.

Instead, would the following work? We send a Stop IPC to the renderer if the
request is renderer-initiated. In the renderer, we have a boolean that records
that the navigation is being handled by the client. Could we fire a
didFailProvisionalLoad with net::ERR_ABORTED when we're told to stop and we
expected the client to be navigating for us?

[ananta, 2017/02/08 23:02:19]

Thanks. FrameLoader::stopAllLoaders() now sends failed provisional load
notifications for client side navigations. 

We still need the provisional load failed notification in
RenderFrameImpl::OnFailedNavigation(). I added a check for doing this only for
renderer initiated navigations. This covers the
http\tests\loading\bad-server-subframe.html layout test

+        navigation_request->common_params().url, error_code);
     frame_tree_node->ResetNavigationRequest(false);
     return;
   }
 
-  // Select an appropriate renderer to show the error page.
-  RenderFrameHostImpl* render_frame_host =
-      frame_tree_node->render_manager()->GetFrameHostForNavigation(
-          *navigation_request);
   CheckWebUIRendererDoesNotDisplayNormalURL(
       render_frame_host, navigation_request->common_params().url);
 
   navigation_request->TransferNavigationHandleOwnership(render_frame_host);
   render_frame_host->navigation_handle()->ReadyToCommitNavigation(
       render_frame_host);
   render_frame_host->FailedNavigation(navigation_request->common_params(),
                                       navigation_request->request_params(),
                                       has_stale_copy_in_cache, error_code);
 }
@@ skipping 234 matching lines @@
     if (navigation_handle)
       navigation_handle->update_entry_id_for_transfer(entry->GetUniqueID());
 
     controller_->SetPendingEntry(std::move(entry));
     if (delegate_)
       delegate_->NotifyChangedNavigationState(content::INVALIDATE_TYPE_URL);
   }
 }
 
 }  // namespace content