Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2687533002:
SwiftShader DEPS update (Closed)
DescriptionSwiftShader DEPS update
This change includes many Subzero related fixes, and adds the
ability to build SwiftShader with the Subzero backend within
SwiftShader simply based on a boolean value inside a BUILD.gn
file but does not yet enable Subzero compilation in Chromium.
TBR=kbr@chromium.org
TBR_REASON=SwiftShader DEPS roll
BUG=630728
Review-Url: https://codereview.chromium.org/2687533002
Cr-Commit-Position: refs/heads/master@{#449860}
Committed: https://chromium.googlesource.com/chromium/src/+/adb1db8ef902542008ba27f5ac141eb095259a1d
Patch Set 1 #Patch Set 2 : Update to SwiftShader ToT #Patch Set 3 : Fixed Linux/Mac interdependent build issues #Messages
Total messages: 21 (18 generated)
The CQ bit was checked by sugoi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== SwiftShader DEPS update This change includes many Subzero related fixes, and adds the ability to build SwiftShader with the Subzero backend within SwiftShader simply based on a boolean value inside a BUILD.gn file but does not yet enable Subzero compilation in Chromium. TBR=kbr@chromium.org BUG=630728 ========== to ========== SwiftShader DEPS update This change includes many Subzero related fixes, and adds the ability to build SwiftShader with the Subzero backend within SwiftShader simply based on a boolean value inside a BUILD.gn file but does not yet enable Subzero compilation in Chromium. TBR=kbr@chromium.org BUG=630728 ==========
sugoi@chromium.org changed reviewers: + capn@chromium.org
The CQ bit was checked by sugoi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sugoi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== SwiftShader DEPS update This change includes many Subzero related fixes, and adds the ability to build SwiftShader with the Subzero backend within SwiftShader simply based on a boolean value inside a BUILD.gn file but does not yet enable Subzero compilation in Chromium. TBR=kbr@chromium.org BUG=630728 ========== to ========== SwiftShader DEPS update This change includes many Subzero related fixes, and adds the ability to build SwiftShader with the Subzero backend within SwiftShader simply based on a boolean value inside a BUILD.gn file but does not yet enable Subzero compilation in Chromium. TBR=kbr@chromium.org TBR_REASON=SwiftShader DEPS roll BUG=630728 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sugoi@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486827372000650,
"parent_rev": "51a5b2534a995d237d881c9a0759d966e76d00ef", "commit_rev":
"adb1db8ef902542008ba27f5ac141eb095259a1d"}
Message was sent while issue was closed.
Description was changed from ========== SwiftShader DEPS update This change includes many Subzero related fixes, and adds the ability to build SwiftShader with the Subzero backend within SwiftShader simply based on a boolean value inside a BUILD.gn file but does not yet enable Subzero compilation in Chromium. TBR=kbr@chromium.org TBR_REASON=SwiftShader DEPS roll BUG=630728 ========== to ========== SwiftShader DEPS update This change includes many Subzero related fixes, and adds the ability to build SwiftShader with the Subzero backend within SwiftShader simply based on a boolean value inside a BUILD.gn file but does not yet enable Subzero compilation in Chromium. TBR=kbr@chromium.org TBR_REASON=SwiftShader DEPS roll BUG=630728 Review-Url: https://codereview.chromium.org/2687533002 Cr-Commit-Position: refs/heads/master@{#449860} Committed: https://chromium.googlesource.com/chromium/src/+/adb1db8ef902542008ba27f5ac14... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/adb1db8ef902542008ba27f5ac14...
Message was sent while issue was closed.
On 2017/02/11 15:40:17, commit-bot: I haz the power wrote: > Committed patchset #3 (id:40001) as > https://chromium.googlesource.com/chromium/src/+/adb1db8ef902542008ba27f5ac14... This cl caused the Linux official builder to break due to some bug in the LLVM gold linker. A workaround for this bug will be landed here: https://codereview.chromium.org/2692823003 |
