Add TEAM/COMPONENT

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to 
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your 
OWNERS files. Thanks. 

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory. 
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
Review-Url: https://codereview.chromium.org/2687493002
Cr-Commit-Position: refs/heads/master@{#452131}
Committed: https://chromium.googlesource.com/chromium/src/+/39607f94bba9da8426f491daf9c7f6d9a52069f9

[ymzhang1, 2017-02-07 19:06:52]

ymzhang@chromium.org changed reviewers:
+ dhnishi@chromium.org

[ymzhang1, 2017-02-07 19:06:52]

Hello,

We are adding COMPONENT/TEAM information into OWNERS file. Would you mind
helping us to verify the added TEAM/COMPONENT or suggest the correct
TEAM/COMPONENT in your OWNERS file? Thank you very much!

[Daniel Nishi, 2017-02-07 19:16:22]

On 2017/02/07 19:06:52, ymzhang1 wrote:
> Hello,
> 
> We are adding COMPONENT/TEAM information into OWNERS file. Would you mind
> helping us to verify the added TEAM/COMPONENT or suggest the correct
> TEAM/COMPONENT in your OWNERS file? Thank you very much!

So, sivachandra@ and myself are no longer on Chrome. I was actually an intern
when I was added to c/b/power. I think derat@ is the only valid person left in
that owners.

I think mgiuca@ is the right person for the installedapp modules.

The component itself looks fine to me, though.

[Daniel Nishi, 2017-02-07 19:17:12]

On 2017/02/07 19:16:22, Daniel Nishi wrote:
> On 2017/02/07 19:06:52, ymzhang1 wrote:
> > Hello,
> > 
> > We are adding COMPONENT/TEAM information into OWNERS file. Would you mind
> > helping us to verify the added TEAM/COMPONENT or suggest the correct
> > TEAM/COMPONENT in your OWNERS file? Thank you very much!
> 
> So, sivachandra@ and myself are no longer on Chrome. I was actually an intern
> when I was added to c/b/power. I think derat@ is the only valid person left in
> that owners.
> 
> I think mgiuca@ is the right person for the installedapp modules.
> 
> The component itself looks fine to me, though.

Actually, I'm not sure if the component is valid, either? installedapp was for
an API for PWAs to query if their native apps were installed. I don't think that
falls under Apps > AppLauncher > Install.

[Daniel Nishi, 2017-02-07 19:17:15]

On 2017/02/07 19:16:22, Daniel Nishi wrote:
> On 2017/02/07 19:06:52, ymzhang1 wrote:
> > Hello,
> > 
> > We are adding COMPONENT/TEAM information into OWNERS file. Would you mind
> > helping us to verify the added TEAM/COMPONENT or suggest the correct
> > TEAM/COMPONENT in your OWNERS file? Thank you very much!
> 
> So, sivachandra@ and myself are no longer on Chrome. I was actually an intern
> when I was added to c/b/power. I think derat@ is the only valid person left in
> that owners.
> 
> I think mgiuca@ is the right person for the installedapp modules.
> 
> The component itself looks fine to me, though.

Actually, I'm not sure if the component is valid, either? installedapp was for
an API for PWAs to query if their native apps were installed. I don't think that
falls under Apps > AppLauncher > Install.

[ymzhang1, 2017-02-07 19:23:50]

Description was changed from

==========
Add TEAM/COMPONENT

BUG=679905
==========

to

==========
Add TEAM/COMPONENT

BUG=679905
==========

[ymzhang1, 2017-02-07 19:23:50]

ymzhang@chromium.org changed reviewers:
+ derat@chromium.org, mgiuca@chromium.org

[ymzhang1, 2017-02-07 19:25:11]

On 2017/02/07 19:17:15, Daniel Nishi wrote:
> On 2017/02/07 19:16:22, Daniel Nishi wrote:
> > On 2017/02/07 19:06:52, ymzhang1 wrote:
> > > Hello,
> > > 
> > > We are adding COMPONENT/TEAM information into OWNERS file. Would you mind
> > > helping us to verify the added TEAM/COMPONENT or suggest the correct
> > > TEAM/COMPONENT in your OWNERS file? Thank you very much!
> > 
> > So, sivachandra@ and myself are no longer on Chrome. I was actually an
intern
> > when I was added to c/b/power. I think derat@ is the only valid person left
in
> > that owners.
> > 
> > I think mgiuca@ is the right person for the installedapp modules.
> > 
> > The component itself looks fine to me, though.
> 
> Actually, I'm not sure if the component is valid, either? installedapp was for
> an API for PWAs to query if their native apps were installed. I don't think
that
> falls under Apps > AppLauncher > Install.

Thanks for the information! I add mgiuca@ and derat@ as reviewers.

[Daniel Erat, 2017-02-07 20:45:41]

do you mind just deleting chrome/browser/power/OWNERS instead? instead? it's
empty apart from that file; i think that the code there was unused and has been
deleted.

lgtm if you do that. :-)

[ymzhang1, 2017-02-07 21:31:54]

On 2017/02/07 20:45:41, Daniel Erat wrote:
> do you mind just deleting chrome/browser/power/OWNERS instead? instead? it's
> empty apart from that file; i think that the code there was unused and has
been
> deleted.
> 
> lgtm if you do that. :-)

Sure. Thanks!

[ymzhang1, 2017-02-07 21:32:44]

Delete chrome/browser/power/OWNERS

[Daniel Erat, 2017-02-08 00:21:42]

lgtm

[ymzhang1, 2017-02-08 00:22:19]

The CQ bit was checked by ymzhang@chromium.org

[commit-bot: I haz the power, 2017-02-08 00:22:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 00:35:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 00:35:46]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ymzhang1, 2017-02-09 23:56:09]

@dhnishi@chromium.org

Do you mind lgtm this cl? There's presubmit error: Missing LGTM from an OWNER
for these files. Thanks!

[Matt Giuca, 2017-02-10 00:44:02]

On 2017/02/09 23:56:09, ymzhang1 wrote:
> mailto:@dhnishi@chromium.org
> 
> Do you mind lgtm this cl? There's presubmit error: Missing LGTM from an OWNER
> for these files. Thanks!

dhnishi doesn't work on Chrome any more. I have taken over his work on
installedapp so maybe you can replace him with me (mgiuca@chromium.org) in this
CL.

[ymzhang1, 2017-02-10 18:04:14]

Thanks Matt for the update! I have put your name on installedapp OWNERS files.

[ymzhang1, 2017-02-13 22:17:33]

Description was changed from

==========
Add TEAM/COMPONENT

BUG=679905
==========

to

==========
BUG=679905
We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct
TEAM/COMPONENT in your OWNERS files. Thanks. 

Proposal to add TEAM/COMPONENT information into OWNERS files
https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST...

Proposal about how to get suggested component for directory. 
https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J...

TEAM-COMPONENT mapping
https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA...
==========

[ymzhang1, 2017-02-13 23:17:44]

Description was changed from

==========
BUG=679905
We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct
TEAM/COMPONENT in your OWNERS files. Thanks. 

Proposal to add TEAM/COMPONENT information into OWNERS files
https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST...

Proposal about how to get suggested component for directory. 
https://docs.google.com/document/d/1G0UD01aNXdzPsJO-gTLEQiKkDV8XU2XBbi_Gm4g9J...

TEAM-COMPONENT mapping
https://docs.google.com/spreadsheets/d/19JEFMvsxD3eThyGiJRqAjcpx362LHUDdVzICA...
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to 
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your 
OWNERS files. Thanks. 

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory. 
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
==========

[ymzhang1, 2017-02-13 23:18:03]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to 
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your 
OWNERS files. Thanks. 

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory. 
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to 
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your 
OWNERS files. Thanks. 

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory. 
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
==========

[ymzhang1, 2017-02-17 23:58:18]

The CQ bit was checked by ymzhang@chromium.org

[ymzhang1, 2017-02-17 23:58:18]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2687493002/#ps40001
(title: "update OWNERS")

[commit-bot: I haz the power, 2017-02-17 23:59:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 02:04:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 02:04:37]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Daniel Nishi, 2017-02-21 20:04:07]

On 2017/02/18 02:04:37, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
> URL)
>   chromeos_amd64-generic_chromium_compile_only_ng on
> master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
>   chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
> (JOB_TIMED_OUT, no build URL)
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build
> URL)
>   linux_chromium_asan_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT,
> no build URL)
>   linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
> (JOB_TIMED_OUT, no build URL)
>   linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
> (JOB_TIMED_OUT, no build URL)
>   linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
> build URL)
>   linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT,
> no build URL)

lgtm

[ymzhang1, 2017-02-21 20:29:45]

The CQ bit was checked by ymzhang@chromium.org

[commit-bot: I haz the power, 2017-02-21 20:31:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Matt Giuca, 2017-02-21 22:22:08]

lgtm in case that will convince the CQ to land?

[commit-bot: I haz the power, 2017-02-21 22:37:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 22:37:40]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[ymzhang1, 2017-02-21 22:52:01]

ymzhang@chromium.org changed reviewers:
+ jochen@chromium.org

[ymzhang1, 2017-02-21 22:52:02]

Hi jochen@

Would you mind helping to lgtm this cl?

We are removing chrome/browser/power/OWNERS since this is the only file under
this directory. Presubmit says I missed lgtm from owner so I think your lgtm
might help. Thanks!

[jochen (gone - plz use gerrit), 2017-02-22 08:57:15]

lgtm

[ymzhang1, 2017-02-22 18:04:27]

The CQ bit was checked by ymzhang@chromium.org

[commit-bot: I haz the power, 2017-02-22 18:05:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 18:15:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487786667325040,
"parent_rev": "a741cc8edf82ff1bf0850f9f8756419d6eaf60d0", "commit_rev":
"39607f94bba9da8426f491daf9c7f6d9a52069f9"}

[commit-bot: I haz the power, 2017-02-22 18:15:47]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to 
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your 
OWNERS files. Thanks. 

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory. 
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to 
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your 
OWNERS files. Thanks. 

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory. 
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905

Review-Url: https://codereview.chromium.org/2687493002
Cr-Commit-Position: refs/heads/master@{#452131}
Committed:
https://chromium.googlesource.com/chromium/src/+/39607f94bba9da8426f491daf9c7...
==========

[commit-bot: I haz the power, 2017-02-22 18:15:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/39607f94bba9da8426f491daf9c7...