Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2687403003: [cleanup] Remove now-unused fields of FunctionState (Closed)

Created:
3 years, 10 months ago by adamk
Modified:
3 years, 10 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com, caitp
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Remove now-unused fields of FunctionState R=marja@chromium.org Review-Url: https://codereview.chromium.org/2687403003 Cr-Commit-Position: refs/heads/master@{#43172} Committed: https://chromium.googlesource.com/v8/v8/+/92f0a618a7e148ead6e650a378999c29663e5592

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M src/parsing/parser-base.h View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
adamk
3 years, 10 months ago (2017-02-10 23:56:40 UTC) #1
marja
lgtm - oops, totally missed these when reviewing the orig. change
3 years, 10 months ago (2017-02-13 08:01:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687403003/1
3 years, 10 months ago (2017-02-13 17:44:23 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/16827) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
3 years, 10 months ago (2017-02-13 17:47:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687403003/1
3 years, 10 months ago (2017-02-13 17:59:44 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/builds/16625) v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
3 years, 10 months ago (2017-02-13 18:02:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687403003/1
3 years, 10 months ago (2017-02-13 23:13:40 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 23:38:18 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/92f0a618a7e148ead6e650a378999c29663...

Powered by Google App Engine
This is Rietveld 408576698