Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2687403002: cros: Moved smart lock tooltip to the left side of the pod. (Closed)

Created:
3 years, 10 months ago by sammiequon
Modified:
3 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Moved smart lock tooltip to the left side of the pod. Previously moved the smart lock icon from the right side of the pod to the left. The tooltip now covers the pod. Move the tooltip be on the left side of the smart lock icon to avoid covering the pod. TEST=none BUG=690748 Review-Url: https://codereview.chromium.org/2687403002 Cr-Commit-Position: refs/heads/master@{#449809} Committed: https://chromium.googlesource.com/chromium/src/+/f0e5e8156b96adf6099b0179c1b6be9d9d7721b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/login/account_picker/user_pod_row.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
sammiequon
xiyuan@ - Please take a look. Thanks!
3 years, 10 months ago (2017-02-10 19:11:34 UTC) #7
xiyuan
lgtm
3 years, 10 months ago (2017-02-10 19:32:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687403002/1
3 years, 10 months ago (2017-02-11 00:51:56 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 00:56:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f0e5e8156b96adf6099b0179c1b6...

Powered by Google App Engine
This is Rietveld 408576698