Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2687393003: Explicitly validate sizes before allocating vectors. (Closed)

Created:
3 years, 10 months ago by Geoff Lang
Modified:
3 years, 10 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly validate sizes before allocating vectors. GLsizei validation is not auto-generated in the passthrough command decoder and is left up to ANGLE's validation but some entry points need to make copies of the data before making GL calls. Make sure the GLsizei is non-negative in these cases. BUG=602737 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2687393003 Cr-Commit-Position: refs/heads/master@{#449864} Committed: https://chromium.googlesource.com/chromium/src/+/3dbb71ef483227725d0167e2fc602a64b07d02f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc View 14 chunks +70 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Geoff Lang
PTAL
3 years, 10 months ago (2017-02-10 20:42:48 UTC) #4
Zhenyao Mo
On 2017/02/10 20:42:48, Geoff Lang wrote: > PTAL lgtm
3 years, 10 months ago (2017-02-10 20:56:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687393003/1
3 years, 10 months ago (2017-02-11 17:00:36 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 17:04:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3dbb71ef483227725d0167e2fc60...

Powered by Google App Engine
This is Rietveld 408576698