Fixed navigation for displayed SSL interstitials.

Fixed navigation for displayed SSL interstitials.

Navigation did not work for interstitials for 2 reasons which are fixed
in this CL:

1.) |WebInterstitialImpl::DontProceed| should not reload.
Reloading stops pending navigation and reloads last committed item,
which is not always correct target item. On other platforms 
InterstitialPageImpl::DontProceed does not reload.

2.) |clearTransientContentView| removes pending item, so it should be
called before pending navigation is initiated. So next
|clearTransientContentView| call will be no-op.

This CL changes the behavior, so when user taps "BACK TO SAFETY" the page
is not reloaded. This is fine, but in order to update omnibox URL, tab
should subscribe to webStateDidDismissInterstitial: callback and update
the toolbar.

BUG=677193, 677190, 688009
Review-Url: https://codereview.chromium.org/2687343003
Cr-Commit-Position: refs/heads/master@{#450220}
Committed: https://chromium.googlesource.com/chromium/src/+/b2517f141263ee8913024a3a96cd909423ad7214

[Eugene But (OOO till 7-30), 2017-02-11 03:16:59]

Description was changed from

==========
Fixed navigation for displayed SSL interstitials.

BUG=677193,677190,688009
==========

to

==========
Fixed navigation for displayed SSL interstitials.

Navigation did not work for interstitials for 2 reasons which are fixed
in this CL:

1.) |WebInterstitialImpl::DontProceed| should not reload.
Reloading stops pending navigation and reloads last committed item,
which is not always correct target item. On other platforms 
InterstitialPageImpl::DontProceed does not reload.

2.) |clearTransientContentView| removes pending item, so it should be
called before pending navigation is initiated. So next
|clearTransientContentView| call will be no-op.

This CL changes the behavior, so when user taps "BACK TO SAFETY" the page
is not reloaded. This is fine, but in order to update omnibox URL, tab
should subscribe to webStateDidDismissInterstitial: callback and update
the toolbar.

BUG=677193,677190,688009
==========

[Eugene But (OOO till 7-30), 2017-02-11 03:17:03]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[Eugene But (OOO till 7-30), 2017-02-11 03:17:14]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[commit-bot: I haz the power, 2017-02-11 03:17:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 03:31:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 03:31:37]

Dry run: This issue passed the CQ dry run.

[kkhorimoto, 2017-02-13 23:52:19]

lgtm

[Eugene But (OOO till 7-30), 2017-02-14 03:06:09]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-02-14 03:07:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 03:21:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487041569722360,
"parent_rev": "6888d15cd136c49fe8c93a1a45c9226a0390f2a6", "commit_rev":
"b2517f141263ee8913024a3a96cd909423ad7214"}

[commit-bot: I haz the power, 2017-02-14 03:22:24]

Description was changed from

==========
Fixed navigation for displayed SSL interstitials.

Navigation did not work for interstitials for 2 reasons which are fixed
in this CL:

1.) |WebInterstitialImpl::DontProceed| should not reload.
Reloading stops pending navigation and reloads last committed item,
which is not always correct target item. On other platforms 
InterstitialPageImpl::DontProceed does not reload.

2.) |clearTransientContentView| removes pending item, so it should be
called before pending navigation is initiated. So next
|clearTransientContentView| call will be no-op.

This CL changes the behavior, so when user taps "BACK TO SAFETY" the page
is not reloaded. This is fine, but in order to update omnibox URL, tab
should subscribe to webStateDidDismissInterstitial: callback and update
the toolbar.

BUG=677193,677190,688009
==========

to

==========
Fixed navigation for displayed SSL interstitials.

Navigation did not work for interstitials for 2 reasons which are fixed
in this CL:

1.) |WebInterstitialImpl::DontProceed| should not reload.
Reloading stops pending navigation and reloads last committed item,
which is not always correct target item. On other platforms 
InterstitialPageImpl::DontProceed does not reload.

2.) |clearTransientContentView| removes pending item, so it should be
called before pending navigation is initiated. So next
|clearTransientContentView| call will be no-op.

This CL changes the behavior, so when user taps "BACK TO SAFETY" the page
is not reloaded. This is fine, but in order to update omnibox URL, tab
should subscribe to webStateDidDismissInterstitial: callback and update
the toolbar.

BUG=677193,677190,688009

Review-Url: https://codereview.chromium.org/2687343003
Cr-Commit-Position: refs/heads/master@{#450220}
Committed:
https://chromium.googlesource.com/chromium/src/+/b2517f141263ee8913024a3a96cd...
==========

[commit-bot: I haz the power, 2017-02-14 03:22:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b2517f141263ee8913024a3a96cd...