Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2687333002: Add shim for EstimateMemoryUsage in Quic (Closed)

Created:
3 years, 10 months ago by xunjieli
Modified:
3 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org, DmitrySkiba
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add shim for EstimateMemoryUsage in Quic This mirrors bnc@'s Spdy change at crrev.com/2686733004. BUG=669108 Review-Url: https://codereview.chromium.org/2687333002 Cr-Commit-Position: refs/heads/master@{#449625} Committed: https://chromium.googlesource.com/chromium/src/+/16e6ce7aaaca9d9f5c078e02552fb276804aa83d

Patch Set 1 #

Patch Set 2 : self #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M net/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A net/quic/platform/api/quic_estimate_memory_usage.h View 1 1 chunk +21 lines, -0 lines 0 comments Download
A net/quic/platform/impl/quic_estimate_memory_usage_impl.h View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
xunjieli
Ryan, PTAL. I also uploaded a CL to internal repo.
3 years, 10 months ago (2017-02-10 14:33:26 UTC) #4
Ryan Hamilton
lgtm
3 years, 10 months ago (2017-02-10 15:12:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687333002/20001
3 years, 10 months ago (2017-02-10 15:24:39 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 15:43:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/16e6ce7aaaca9d9f5c078e02552f...

Powered by Google App Engine
This is Rietveld 408576698