ios/chrome/browser/tabs/tab_model_tab_model_observers_bridge.h - Issue 2687303003: Convert some of TabModel logic to WebStateListObservers.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/tabs/tab_model_tab_model_observers_bridge.h

Issue 2687303003: Convert some of TabModel logic to WebStateListObservers. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/chrome/browser/tabs/tab_model_metrics_observer.mm ('K') | « ios/chrome/browser/tabs/tab_model_metrics_observer.mm ('k') | ios/chrome/browser/tabs/tab_model_tab_model_observers_bridge.mm » ('j') | ios/chrome/browser/tabs/tab_model_tab_parenting_observer.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_TABS_TAB_MODEL_TAB_MODEL_OBSERVERS_BRIDGE_H_

	6 #define IOS_CHROME_BROWSER_TABS_TAB_MODEL_TAB_MODEL_OBSERVERS_BRIDGE_H_

	7

	8 #import "ios/shared/chrome/browser/tabs/web_state_list_observer_bridge.h"

	9

	10 @class TabModel;

	11 @class TabModelObservers;

	12

	13 // Bridge WebStateListObserver events to TabModelObservers.

	14 @interface TabModelTabModelObserversBridge : NSObject<WebStateListObserver>
	marq (ping after 24h) 2017/02/13 17:06:54 Can this just be TabModelObserversBridge? Can this just be TabModelObserversBridge? sdefresne 2017/02/14 17:19:38 Done. I've kept this object in Objective-C as it Show quoted text On 2017/02/13 17:06:54, marq wrote: > Can this just be TabModelObserversBridge? Done. I've kept this object in Objective-C as it allows me to use ARC for implementation. Changing this to C++ would require moving the __weak annotated pointer into the header file which does not work with ARC, thus requiring the use of __unsafe_unretained. As the class is short lived, I think using Objective-C makes the code simpler.
	15

	16 - (instancetype)initWithTabModel:(TabModel*)tabModel

	17 tabModelObservers:(TabModelObservers*)tabModelObservers

	18 NS_DESIGNATED_INITIALIZER;

	19

	20 - (instancetype)init NS_UNAVAILABLE;

	21

	22 @end

	23

	24 #endif // IOS_CHROME_BROWSER_TABS_TAB_MODEL_TAB_MODEL_OBSERVERS_BRIDGE_H_

OLD	NEW