Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2687293002: Set more consistent conditionals for the use mash flag (Closed)

Created:
3 years, 10 months ago by fwang
Modified:
3 years, 10 months ago
Reviewers:
sky, mfomitchev
CC:
chromium-reviews, srahim+watch_chromium.org, rjkroege, Tom (Use chromium acct), tonikitoo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set more consistent conditionals for the use mash flag In [1], the mash flag was moved outside a ChromeOS conditional (and inside an "enable mash services" conditional). However, the corresponding resource definitions in generated_resources.grd were kept inside a ChromeOS conditional. This broke non-ChromeOS builds when the mash services are enabled, as it is the case for example with the Ozone Linux OS bot [2]. This CL moves the resource definitions outside the ChromeOS conditional. BUG=None [1] https://codereview.chromium.org/2681663004/ [2] https://build.chromium.org/p/chromium.fyi/builders/Ozone%20Linux

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -6 lines 1 comment Download

Messages

Total messages: 13 (7 generated)
fwang
PTAL
3 years, 10 months ago (2017-02-10 08:48:50 UTC) #2
mfomitchev
https://codereview.chromium.org/2687293002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2687293002/diff/1/chrome/app/generated_resources.grd#newcode5793 chrome/app/generated_resources.grd:5793: + <message name="IDS_FLAGS_USE_MASH_NAME" desc="Name for the flag to enable ...
3 years, 10 months ago (2017-02-10 14:37:47 UTC) #8
fwang
On 2017/02/10 14:37:47, mfomitchev wrote: > So I am inclined to move the flag definition ...
3 years, 10 months ago (2017-02-10 14:48:58 UTC) #9
sky
On 2017/02/10 14:48:58, fwang wrote: > On 2017/02/10 14:37:47, mfomitchev wrote: > > So I ...
3 years, 10 months ago (2017-02-10 18:57:15 UTC) #10
mfomitchev
On 2017/02/10 18:57:15, sky wrote: > On 2017/02/10 14:48:58, fwang wrote: > > On 2017/02/10 ...
3 years, 10 months ago (2017-02-10 19:44:34 UTC) #11
fwang
3 years, 10 months ago (2017-02-10 20:37:06 UTC) #12
On 2017/02/10 19:44:34, mfomitchev wrote:
> I am not sure what hours is fwang working, and I don't want to leave the bot
> failing for too long, so I am going to put up a CL.
> fwang: Thanks again for looking into this!

Thank you for taking care of this.

Powered by Google App Engine
This is Rietveld 408576698