Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2687233002: Enabled testHistoryUpdateAfterBackNavigation. (Closed)

Created:
3 years, 10 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 10 months ago
Reviewers:
baxley
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enabled testHistoryUpdateAfterBackNavigation. BUG=688047 Review-Url: https://codereview.chromium.org/2687233002 Cr-Commit-Position: refs/heads/master@{#450189} Committed: https://chromium.googlesource.com/chromium/src/+/3e0da344ce088f22ac29af6084d5fb7b83f3624f

Patch Set 1 #

Patch Set 2 : Merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ios/chrome/browser/ui/history/history_ui_egtest.mm View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Eugene But (OOO till 7-30)
I will not CQ this until fix is landed: https://codereview.chromium.org/2691693002/ But please take a look
3 years, 10 months ago (2017-02-11 02:00:48 UTC) #6
baxley
lgtm
3 years, 10 months ago (2017-02-13 14:14:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687233002/20001
3 years, 10 months ago (2017-02-14 01:17:45 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 01:34:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3e0da344ce088f22ac29af6084d5...

Powered by Google App Engine
This is Rietveld 408576698