Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2687223002: nit: Use Title Case for "Select All" in views::Textfield context menus on Mac. (Closed)

Created:
3 years, 10 months ago by tapted
Modified:
3 years, 10 months ago
Reviewers:
spqchan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

nit: Use Title Case for "Select All" in views::Textfield context menus on Mac. It currently isn't (and there's now "Look Up", which is). BUG=617436 Review-Url: https://codereview.chromium.org/2687223002 Cr-Commit-Position: refs/heads/master@{#449900} Committed: https://chromium.googlesource.com/chromium/src/+/671ec2e35979d2656757bc3771af54c6190efb91

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M ui/strings/ui_strings.grd View 1 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
tapted
HI Sarah, please take a look :)
3 years, 10 months ago (2017-02-10 05:31:08 UTC) #10
spqchan
lgtm
3 years, 10 months ago (2017-02-10 17:41:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687223002/20001
3 years, 10 months ago (2017-02-12 22:43:42 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 00:03:28 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/671ec2e35979d2656757bc3771af...

Powered by Google App Engine
This is Rietveld 408576698