Add a build arg to control whether to use a jessie sysroot.

Add a build arg to control whether to use a jessie sysroot.

We're working on a class of changes in the Linux desktop UI
that won't work on Precise; they need newer Linux versions
that basically amount to needing to link against the Debian
Jessie sysroot instead of the Debian Wheezy sysroot. Previously
we were working around this by checking whether we were building
with ozone + use_kbdcommon, but that caused a dependency inversion
by making //build depend on //ui.

This changes adds a dedicated GN build arg, use_jessie_sysroot,
that we'll explicitly set instead, and that way we can avoid
the dependency inversion.

R=thomasanderson@chromium.org, tonikitoo@igalia.com
BUG=564904
Review-Url: https://codereview.chromium.org/2687203002
Cr-Commit-Position: refs/heads/master@{#449505}
Committed: https://chromium.googlesource.com/chromium/src/+/657454d7091e2d6108703305a6ba1d4904df98a0

[Dirk Pranke, 2017-02-09 23:49:31]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 23:50:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2017-02-09 23:51:17]

thomasanderson@ - please take a look.

Everyone else: FYI, this fixes the //build layering violation.

If you were doing local builds in this configuration you'll need to add this new
GN arg as well.

[Tom Anderson, 2017-02-09 23:56:28]

lgtm

[tonikitoo, 2017-02-10 00:19:59]

On 2017/02/09 23:56:28, Thomas Anderson wrote:
> lgtm

lgtm , but sould we chance
https://cs.chromium.org/chromium/src/build/linux/sysroot_scripts/install-sysr...
too ?

[tonikitoo, 2017-02-10 00:20:42]

On 2017/02/10 00:19:59, tonikitoo wrote:
> On 2017/02/09 23:56:28, Thomas Anderson wrote:
> > lgtm
> 
> lgtm , but sould we chance
>
https://cs.chromium.org/chromium/src/build/linux/sysroot_scripts/install-sysr...
> too ?

oh, that is a GYP define actually :(

[Tom (Use chromium acct), 2017-02-10 00:26:06]

On 2017/02/10 00:20:42, tonikitoo wrote:
> On 2017/02/10 00:19:59, tonikitoo wrote:
> > On 2017/02/09 23:56:28, Thomas Anderson wrote:
> > > lgtm
> > 
> > lgtm , but sould we chance
> >
>
https://cs.chromium.org/chromium/src/build/linux/sysroot_scripts/install-sysr...
> > too ?
> 
> oh, that is a GYP define actually :(

I think it should be ok to always download the jessie sysroot on ozone.  There
will be some cases where we download it but don't need it, but who cares?

[Dirk Pranke, 2017-02-10 00:44:41]

On 2017/02/10 00:26:06, Tom Anderson wrote:
> On 2017/02/10 00:20:42, tonikitoo wrote:
> > On 2017/02/10 00:19:59, tonikitoo wrote:
> > > On 2017/02/09 23:56:28, Thomas Anderson wrote:
> > > > lgtm
> > > 
> > > lgtm , but sould we chance
> > >
> >
>
https://cs.chromium.org/chromium/src/build/linux/sysroot_scripts/install-sysr...
> > > too ?
> > 
> > oh, that is a GYP define actually :(
> 
> I think it should be ok to always download the jessie sysroot on ozone.  There
> will be some cases where we download it but don't need it, but who cares?

Yup, that's my thinking too. Hopefully we're only a couple weeks away from just
switching over now.

[commit-bot: I haz the power, 2017-02-10 00:51:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 00:51:48]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2017-02-10 00:59:32]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2017-02-10 01:00:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 01:27:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486688372341350, "parent_rev":
"20f1a16e0ed6c595f50df84cb829e7f4fe842fd3", "commit_rev":
"657454d7091e2d6108703305a6ba1d4904df98a0"}

[commit-bot: I haz the power, 2017-02-10 01:28:26]

Description was changed from

==========
Add a build arg to control whether to use a jessie sysroot.

We're working on a class of changes in the Linux desktop UI
that won't work on Precise; they need newer Linux versions
that basically amount to needing to link against the Debian
Jessie sysroot instead of the Debian Wheezy sysroot. Previously
we were working around this by checking whether we were building
with ozone + use_kbdcommon, but that caused a dependency inversion
by making //build depend on //ui.

This changes adds a dedicated GN build arg, use_jessie_sysroot,
that we'll explicitly set instead, and that way we can avoid
the dependency inversion.

R=thomasanderson@chromium.org, tonikitoo@igalia.com
BUG=564904
==========

to

==========
Add a build arg to control whether to use a jessie sysroot.

We're working on a class of changes in the Linux desktop UI
that won't work on Precise; they need newer Linux versions
that basically amount to needing to link against the Debian
Jessie sysroot instead of the Debian Wheezy sysroot. Previously
we were working around this by checking whether we were building
with ozone + use_kbdcommon, but that caused a dependency inversion
by making //build depend on //ui.

This changes adds a dedicated GN build arg, use_jessie_sysroot,
that we'll explicitly set instead, and that way we can avoid
the dependency inversion.

R=thomasanderson@chromium.org, tonikitoo@igalia.com
BUG=564904

Review-Url: https://codereview.chromium.org/2687203002
Cr-Commit-Position: refs/heads/master@{#449505}
Committed:
https://chromium.googlesource.com/chromium/src/+/657454d7091e2d6108703305a6ba...
==========

[commit-bot: I haz the power, 2017-02-10 01:28:29]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/657454d7091e2d6108703305a6ba...