Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 10 months ago by sof Modified:
3 years, 10 months ago Reviewers:
dcheng CC:
chromium-reviews, blink-reviews, dtapuska+blinkwatch_chromium.org, Navid Zolghadr Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTie DragState to DragController.
Clarify ownership & scope of DragState and have the page's
DragController own it.
R=dcheng
BUG=688569
Review-Url: https://codereview.chromium.org/2687193004
Cr-Commit-Position: refs/heads/master@{#449889}
Committed: https://chromium.googlesource.com/chromium/src/+/5834a2a96dc118c2c247e1a6f0155ed445a7db7b
Patch Set 1 #Patch Set 2 : tidy up DragState resetting #
Created: 3 years, 10 months ago
Dependent Patchsets: Messages
Total messages: 29 (25 generated)
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
Description was changed from ========== Have MouseEventManager manage a DragState. Turn the dragState() singleton into a MouseEventManager member, clarifying ownership. R= BUG= ========== to ========== Tie DragState to DragController. Clarify ownership & scope of DragState and have the page's DragController own it. R= BUG= ==========
Patchset #1 (id:1) has been deleted
sigbjornf@opera.com changed reviewers: + dcheng@chromium.org
please take a look.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Tie DragState to DragController. Clarify ownership & scope of DragState and have the page's DragController own it. R= BUG= ========== to ========== Tie DragState to DragController. Clarify ownership & scope of DragState and have the page's DragController own it. R= BUG=688569 ==========
lgtm
Description was changed from ========== Tie DragState to DragController. Clarify ownership & scope of DragState and have the page's DragController own it. R= BUG=688569 ========== to ========== Tie DragState to DragController. Clarify ownership & scope of DragState and have the page's DragController own it. R=dcheng BUG=688569 ==========
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486889305399150,
"parent_rev": "a537597237c4cb31028478d185e394784b961ec6", "commit_rev":
"5834a2a96dc118c2c247e1a6f0155ed445a7db7b"}
Message was sent while issue was closed.
Description was changed from ========== Tie DragState to DragController. Clarify ownership & scope of DragState and have the page's DragController own it. R=dcheng BUG=688569 ========== to ========== Tie DragState to DragController. Clarify ownership & scope of DragState and have the page's DragController own it. R=dcheng BUG=688569 Review-Url: https://codereview.chromium.org/2687193004 Cr-Commit-Position: refs/heads/master@{#449889} Committed: https://chromium.googlesource.com/chromium/src/+/5834a2a96dc118c2c247e1a6f015... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/5834a2a96dc118c2c247e1a6f015... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
