Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2687193004: Tie DragState to DragController. (Closed)

Created:
3 years, 10 months ago by sof
Modified:
3 years, 10 months ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews, dtapuska+blinkwatch_chromium.org, Navid Zolghadr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tie DragState to DragController. Clarify ownership & scope of DragState and have the page's DragController own it. R=dcheng BUG=688569 Review-Url: https://codereview.chromium.org/2687193004 Cr-Commit-Position: refs/heads/master@{#449889} Committed: https://chromium.googlesource.com/chromium/src/+/5834a2a96dc118c2c247e1a6f0155ed445a7db7b

Patch Set 1 #

Patch Set 2 : tidy up DragState resetting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -12 lines) Patch
M third_party/WebKit/Source/core/input/MouseEventManager.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/MouseEventManager.cpp View 1 6 chunks +14 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/page/DragController.h View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/DragController.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 29 (25 generated)
sof
please take a look.
3 years, 10 months ago (2017-02-10 12:16:27 UTC) #15
dcheng
lgtm
3 years, 10 months ago (2017-02-12 08:30:52 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687193004/60001
3 years, 10 months ago (2017-02-12 08:48:37 UTC) #26
commit-bot: I haz the power
3 years, 10 months ago (2017-02-12 10:33:43 UTC) #29
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5834a2a96dc118c2c247e1a6f015...

Powered by Google App Engine
This is Rietveld 408576698