android: Report child exception by crashing

android: Report child exception by crashing

This is the second attempt of
https://codereview.chromium.org/2677563006/

DumpWithoutCrash should not be enabled for child processes on Android
because the browser is not set up to read multiple crash reports for the
same child process. So enabling DumpWithoutCrash could lead to real crash
reports getting dropped.

This new implementation just crashes the child process to cause a crash
report to be generated.

Note this does not replace the need for
KillChildUncaughtExceptionHandler, which is installed much earlier
during start up and is designed to not cause hangs for any problems
during start up as well.

BUG=680775
Review-Url: https://codereview.chromium.org/2687193003
Cr-Commit-Position: refs/heads/master@{#449632}
Committed: https://chromium.googlesource.com/chromium/src/+/328eda136de7172f4970f94774ba68528ab22adc

[boliu, 2017-02-09 23:10:36]

boliu@chromium.org changed reviewers:
+ tobiasjs@chromium.org, torne@chromium.org

[boliu, 2017-02-09 23:10:36]

ptal, no longer using DumpWithoutCrash

I dunno how hard it would be to make DumpWithoutCrash actually work..

Used LOG(FATAL) here, but I also see other code trigger segfault by
dereferencing null pointer, not sure which is better.

[boliu, 2017-02-09 23:12:33]

On 2017/02/09 23:10:36, boliu wrote:
> ptal, no longer using DumpWithoutCrash
> 
> I dunno how hard it would be to make DumpWithoutCrash actually work..
> 
> Used LOG(FATAL) here, but I also see other code trigger segfault by
> dereferencing null pointer, not sure which is better.

Also managed to produce an actual report from local build:
crash/b0ada1d580000000

[Tobias Sargeant, 2017-02-10 11:29:27]

On 2017/02/09 23:12:33, boliu wrote:
> On 2017/02/09 23:10:36, boliu wrote:
> > ptal, no longer using DumpWithoutCrash
> > 
> > I dunno how hard it would be to make DumpWithoutCrash actually work..
> > 
> > Used LOG(FATAL) here, but I also see other code trigger segfault by
> > dereferencing null pointer, not sure which is better.
> 
> Also managed to produce an actual report from local build:
> crash/b0ada1d580000000

approach LGTM. I think LOG(FATAL) is the best way to terminate the process. I
guess these crashes weren't getting reported before, so landing this might cause
a (small, hopefully) spike in crashes.

[Torne, 2017-02-10 12:02:48]

LGTM

[boliu, 2017-02-10 14:54:23]

boliu@chromium.org changed reviewers:
+ grt@chromium.org, rsesek@chromium.org

[boliu, 2017-02-10 14:54:24]

+grt for chrome/app again
+rsesek for breakpad

[grt (UTC plus 2), 2017-02-10 15:43:02]

chrome/app lgtm

[Robert Sesek, 2017-02-10 15:43:46]

lgtm

[boliu, 2017-02-10 15:46:34]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2017-02-10 15:46:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 16:40:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486741594546880, "parent_rev":
"013b74c8a427c4ec9a5465a6060f626db8cacfd5", "commit_rev":
"328eda136de7172f4970f94774ba68528ab22adc"}

[commit-bot: I haz the power, 2017-02-10 16:40:35]

Description was changed from

==========
android: Report child exception by crashing

This is the second attempt of
https://codereview.chromium.org/2677563006/

DumpWithoutCrash should not be enabled for child processes on Android
because the browser is not set up to read multiple crash reports for the
same child process. So enabling DumpWithoutCrash could lead to real crash
reports getting dropped.

This new implementation just crashes the child process to cause a crash
report to be generated.

Note this does not replace the need for
KillChildUncaughtExceptionHandler, which is installed much earlier
during start up and is designed to not cause hangs for any problems
during start up as well.

BUG=680775
==========

to

==========
android: Report child exception by crashing

This is the second attempt of
https://codereview.chromium.org/2677563006/

DumpWithoutCrash should not be enabled for child processes on Android
because the browser is not set up to read multiple crash reports for the
same child process. So enabling DumpWithoutCrash could lead to real crash
reports getting dropped.

This new implementation just crashes the child process to cause a crash
report to be generated.

Note this does not replace the need for
KillChildUncaughtExceptionHandler, which is installed much earlier
during start up and is designed to not cause hangs for any problems
during start up as well.

BUG=680775

Review-Url: https://codereview.chromium.org/2687193003
Cr-Commit-Position: refs/heads/master@{#449632}
Committed:
https://chromium.googlesource.com/chromium/src/+/328eda136de7172f4970f94774ba...
==========

[commit-bot: I haz the power, 2017-02-10 16:40:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/328eda136de7172f4970f94774ba...