Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2687173002: [Prerender] Ignores resources with unsupported schemes for Offline reqs (Closed)

Created:
3 years, 10 months ago by Pete Williamson
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Prerender] Ignores resources with unsupported schemes for Offline reqs For offlining a page with the prerender, this changes the policy when encountering a resource with an unsupported scheme - instread of failing the prerender (as is done with other prerender requests), it will only cancel the unsupported resource and attempt to continue with prerendering. This has been tested end-end on 5 articles linked from www.foxsports.com that have a "blob:" subresource and with this change, we are able to download and offline version of them. BUG=686192 Review-Url: https://codereview.chromium.org/2661703002 Cr-Commit-Position: refs/heads/master@{#449337} (cherry picked from commit f1ba435af9338792a78fc422eb9cd1a51a14aa13) Review-Url: https://codereview.chromium.org/2687173002 . Cr-Commit-Position: refs/branch-heads/2987@{#417} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/0aeb5cf9de7fd0003d7a4323ab46e5e10d500d30

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -7 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_resource_throttle.cc View 1 chunk +12 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Pete Williamson
3 years, 10 months ago (2017-02-09 21:27:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0aeb5cf9de7fd0003d7a4323ab46e5e10d500d30.

Powered by Google App Engine
This is Rietveld 408576698