Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2687153003: [sync] Adjust ProfileSyncServiceStartupTest to do more crypto (Closed)

Created:
3 years, 10 months ago by Patrick Noland
Modified:
3 years, 10 months ago
Reviewers:
skym
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sync] Adjust ProfileSyncServiceStartupTest to do more crypto Make the password non-empty, and add a mock call to the DataTypeManager so that the FirstTime test passes. This test fails when the previous patch for this bug is reverted. BUG=690669 R=skym@chromium.org Review-Url: https://codereview.chromium.org/2687153003 Cr-Commit-Position: refs/heads/master@{#449730} Committed: https://chromium.googlesource.com/chromium/src/+/377e0fd43c46e071986ea50c16b223cc4a5d40aa

Patch Set 1 #

Patch Set 2 : Add EXPECT_CALL to the other tests that need it #

Patch Set 3 : Switch to ON_CALL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M components/browser_sync/profile_sync_service_startup_unittest.cc View 1 2 7 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 20 (16 generated)
Patrick Noland
3 years, 10 months ago (2017-02-10 18:31:03 UTC) #2
skym
lgtm
3 years, 10 months ago (2017-02-10 18:47:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687153003/40001
3 years, 10 months ago (2017-02-10 20:49:41 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 20:58:29 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/377e0fd43c46e071986ea50c16b2...

Powered by Google App Engine
This is Rietveld 408576698