[heap] no longer perform GC to make heap iterable.

[heap] no longer perform GC to make heap iterable.

Sometimes we do want to include objects that are already dead.

R=hpayer@chromium.org
BUG=v8:5808
Review-Url: https://codereview.chromium.org/2687113002
Cr-Commit-Position: refs/heads/master@{#43083}
Committed: https://chromium.googlesource.com/v8/v8/+/1e3773081fedb79eb91998beb5ce9b6d3f632489

[Yang, 2017-02-09 14:57:01]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 14:57:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 15:32:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 15:32:46]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/20693)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[Yang, 2017-02-09 18:37:59]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 18:38:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 19:01:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 19:01:34]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2017-02-10 07:37:18]

lgtm

https://codereview.chromium.org/2687113002/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2687113002/diff/1/src/heap/heap.cc#newcode4070
src/heap/heap.cc:4070: void Heap::MakeHeapIterable() {
FYI: We do not need to wait for sweepers to make the heap iterable. However, it
is easier to do that to avoid races with the sweeper while iterating.

[Yang, 2017-02-10 08:24:51]

On 2017/02/10 07:37:18, Hannes Payer wrote:
> lgtm
> 
> https://codereview.chromium.org/2687113002/diff/1/src/heap/heap.cc
> File src/heap/heap.cc (right):
> 
> https://codereview.chromium.org/2687113002/diff/1/src/heap/heap.cc#newcode4070
> src/heap/heap.cc:4070: void Heap::MakeHeapIterable() {
> FYI: We do not need to wait for sweepers to make the heap iterable. However,
it
> is easier to do that to avoid races with the sweeper while iterating.

As discussed offline, we don't like races :)

[Yang, 2017-02-10 08:24:55]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2017-02-10 08:25:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 08:26:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486715095071480, "parent_rev":
"8422e25bb26449e0cf9831adafec48ee4e592278", "commit_rev":
"1e3773081fedb79eb91998beb5ce9b6d3f632489"}

[commit-bot: I haz the power, 2017-02-10 08:26:50]

Description was changed from

==========
[heap] no longer perform GC to make heap iterable.

Sometimes we do want to include objects that are already dead.

R=hpayer@chromium.org
BUG=v8:5808
==========

to

==========
[heap] no longer perform GC to make heap iterable.

Sometimes we do want to include objects that are already dead.

R=hpayer@chromium.org
BUG=v8:5808

Review-Url: https://codereview.chromium.org/2687113002
Cr-Commit-Position: refs/heads/master@{#43083}
Committed:
https://chromium.googlesource.com/v8/v8/+/1e3773081fedb79eb91998beb5ce9b6d3f6...
==========

[commit-bot: I haz the power, 2017-02-10 08:26:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1e3773081fedb79eb91998beb5ce9b6d3f6...