Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2687103002: s390: [iwyu] Remove include debug.h -> arguments.h (Closed)

Created:
3 years, 10 months ago by JaideepBajwa
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: [iwyu] Remove include debug.h -> arguments.h Port e425079b1d91a9927a638e9ca7f7fd079773b4f8 Minor fix to the s390 port. Original Commit Message: arguments.h is one of the headers including objects-inl.h. Files needing objects-inl.h used to innocently pull in debug.h, so that needs to be fixed now too. R=marja@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5294 LOG=N Review-Url: https://codereview.chromium.org/2687103002 Cr-Commit-Position: refs/heads/master@{#43073} Committed: https://chromium.googlesource.com/v8/v8/+/a9b2edc1f2b5ec31b47991d7ea296b741aefa9b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/s390/assembler-s390.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
JaideepBajwa
ptal
3 years, 10 months ago (2017-02-09 13:15:17 UTC) #1
john.yan
lgtm
3 years, 10 months ago (2017-02-09 14:49:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687103002/1
3 years, 10 months ago (2017-02-09 14:54:25 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/20699) v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 10 months ago (2017-02-09 15:18:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687103002/1
3 years, 10 months ago (2017-02-09 15:21:35 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/20702) v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 10 months ago (2017-02-09 15:55:26 UTC) #10
marja
lgtm + thanks for the fix!
3 years, 10 months ago (2017-02-09 16:17:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687103002/1
3 years, 10 months ago (2017-02-09 19:58:50 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 20:19:46 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a9b2edc1f2b5ec31b47991d7ea296b741ae...

Powered by Google App Engine
This is Rietveld 408576698