third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h - Issue 2687073003: Make disabling 2d canvas GPU acceleration for getImageData less aggressive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h

Issue 2687073003: Make disabling 2d canvas GPU acceleration for getImageData less aggressive. (Closed)

Patch Set: Address comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp ('k') | third_party/WebKit/Source/platform/graphics/ImageBuffer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h

diff --git a/third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h b/third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h

index 3fbcba25c6fc5aa2fd80d8728e68a2a9cc3e97b8..340d96c18cdad3d3be5e7ccd661c0d8d67cdac16 100644

--- a/third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h

+++ b/third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h

@@ -78,7 +78,11 @@ enum {

// GPU readback prevention heuristics

//====================================

- GetImageDataForcesNoAcceleration = 1,

+ GPUReadbackForcesNoAcceleration = 1,

+ // When gpu readback is successively invoked in following number of frames,

+ // we disable gpu acceleration to avoid the high cost of gpu readback.

+ GPUReadbackMinSuccessiveFrames = 3,

// When a canvas is used as a source image, if its destination is

// non-accelerated and the source canvas is accelerated, a readback