Temporary disable DCHECK for transform ancestor checking in CompositedLayerMapping

Temporary disable DCHECK for transform ancestor checking in CompositedLayerMapping

This patch disables |DCHECK()| fro transform ancestor checking in
|CompositedLayerMapping| for landing [1] and [2].

As of offline discussion, this DCHECK itself can be safely ignored since there
is no stability or security implication, and doesn't result in rendering glitch
in this particular case. However, it is hard to make minimal reproduce case;
this DCHECK hits on |LoginTest.GaiaAuthOffline| which is run on ChromeOS only.

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized positions
[2] http://crrev.com/2340463002 Set default focus on offline signin page

BUG=646437
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2687043002
Cr-Commit-Position: refs/heads/master@{#449539}
Committed: https://chromium.googlesource.com/chromium/src/+/a22b0b4b1401f49e388eef9f96d5cf22e2b5fa08

[yosin_UTC9, 2017-02-09 05:01:29]

Description was changed from

==========
2017-02-09T14:00:56

2017-02-09T14:00:36

BUG=
==========

to

==========
2017-02-09T14:00:56

2017-02-09T14:00:36

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[yosin_UTC9, 2017-02-09 05:02:29]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 05:03:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-02-09 05:10:31]

Description was changed from

==========
2017-02-09T14:00:56

2017-02-09T14:00:36

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Temporary disable DCHECK for transform ancestor checking in
CompositedLayerMapping

This patch disables |DCHECK()| fro transform ancestor checking in
|CompositedLayerMapping| for landing [1] and [2].

As of offline discussion, this DCHECK itself can be safely ignored since there
is no stability or security implication, and doesn't result in rendering glitch
in this particular case. However, it is hard to make minimal reproduce case;
this DCHECK hits on |LoginTest.GaiaAuthOffline| which is run on ChromeOS only.

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions
[2] http://crrev.com/2340463002 Set default focus on offline signin page

BUG=646437
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-09 05:12:56]

yosin@chromium.org changed reviewers:
+ trchen@chromium.org

[yosin_UTC9, 2017-02-09 05:12:57]

PTAL

Sorry about this. I've also attempted to find the root cause but I could not.
:-<
This DCHECK is blocker of editing OKR[1]. We would like land [1] ASAP to meet
our
schedule.

[1] http://crrev.com/2680943004: Make FrameSelection to hold non-canonicalized
positions

[commit-bot: I haz the power, 2017-02-09 06:31:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 06:31:29]

Dry run: This issue passed the CQ dry run.

[trchen, 2017-02-10 01:44:44]

The CQ bit was checked by trchen@chromium.org

[trchen, 2017-02-10 01:44:45]

lgtm

[commit-bot: I haz the power, 2017-02-10 01:45:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 01:51:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 01:51:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yosin_UTC9, 2017-02-10 02:10:12]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2017-02-10 02:10:13]

Kent-san, could you rubber stamping this?
This patch is for landing [1].

[1] http://crrev.com/2680943004: Make FrameSelection to hold non-canonicalized
positions

[tkent, 2017-02-10 02:51:30]

rs lgtm

[tkent, 2017-02-10 02:51:36]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-02-10 02:51:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 02:57:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486695096359280,
"parent_rev": "b4f0e124c5a8884a16459c67d956d011be8acc5a", "commit_rev":
"a22b0b4b1401f49e388eef9f96d5cf22e2b5fa08"}

[commit-bot: I haz the power, 2017-02-10 02:58:08]

Description was changed from

==========
Temporary disable DCHECK for transform ancestor checking in
CompositedLayerMapping

This patch disables |DCHECK()| fro transform ancestor checking in
|CompositedLayerMapping| for landing [1] and [2].

As of offline discussion, this DCHECK itself can be safely ignored since there
is no stability or security implication, and doesn't result in rendering glitch
in this particular case. However, it is hard to make minimal reproduce case;
this DCHECK hits on |LoginTest.GaiaAuthOffline| which is run on ChromeOS only.

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions
[2] http://crrev.com/2340463002 Set default focus on offline signin page

BUG=646437
TEST=n/a; no behavior changes
==========

to

==========
Temporary disable DCHECK for transform ancestor checking in
CompositedLayerMapping

This patch disables |DCHECK()| fro transform ancestor checking in
|CompositedLayerMapping| for landing [1] and [2].

As of offline discussion, this DCHECK itself can be safely ignored since there
is no stability or security implication, and doesn't result in rendering glitch
in this particular case. However, it is hard to make minimal reproduce case;
this DCHECK hits on |LoginTest.GaiaAuthOffline| which is run on ChromeOS only.

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions
[2] http://crrev.com/2340463002 Set default focus on offline signin page

BUG=646437
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2687043002
Cr-Commit-Position: refs/heads/master@{#449539}
Committed:
https://chromium.googlesource.com/chromium/src/+/a22b0b4b1401f49e388eef9f96d5...
==========

[commit-bot: I haz the power, 2017-02-10 02:58:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a22b0b4b1401f49e388eef9f96d5...