[WebPayments] Enabling PaymentRequest on Mac

chrome/browser/ui/BUILD.gn

Index: chrome/browser/ui/BUILD.gn
diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
index 42588ca800ca70bf7b355a2103e13b171e6b49f6..be72477c73a7833cd61e5cf426af801bd2de7d3c 100644
--- a/chrome/browser/ui/BUILD.gn
+++ b/chrome/browser/ui/BUILD.gn
@@ -1518,6 +1518,31 @@ split_static_library("ui") {
       "views/login_view.h",
       "views/new_back_shortcut_bubble.cc",
       "views/new_back_shortcut_bubble.h",
+      "views/payments/credit_card_editor_view_controller.cc",
+      "views/payments/credit_card_editor_view_controller.h",
+      "views/payments/editor_view_controller.cc",
+      "views/payments/editor_view_controller.h",
+      "views/payments/order_summary_view_controller.cc",
+      "views/payments/order_summary_view_controller.h",
+      "views/payments/payment_method_view_controller.cc",
+      "views/payments/payment_method_view_controller.h",
+      "views/payments/payment_request_dialog_view.cc",
+      "views/payments/payment_request_dialog_view.h",
+      "views/payments/payment_request_dialog_view_ids.h",
+      "views/payments/payment_request_row_view.cc",
+      "views/payments/payment_request_row_view.h",
+      "views/payments/payment_request_sheet_controller.cc",
+      "views/payments/payment_request_sheet_controller.h",
+      "views/payments/payment_request_views_util.cc",
+      "views/payments/payment_request_views_util.h",
+      "views/payments/payment_sheet_view_controller.cc",
+      "views/payments/payment_sheet_view_controller.h",
+      "views/payments/shipping_list_view_controller.cc",
+      "views/payments/shipping_list_view_controller.h",
+      "views/payments/validating_textfield.cc",
+      "views/payments/validating_textfield.h",
+      "views/payments/view_stack.cc",
+      "views/payments/view_stack.h",
       "views/subtle_notification_view.cc",
       "views/subtle_notification_view.h",
       "views/sync/bubble_sync_promo_view.cc",
@@ -1799,31 +1824,6 @@ split_static_library("ui") {
         "views/passwords/manage_passwords_bubble_view.h",
         "views/passwords/manage_passwords_icon_views.cc",
         "views/passwords/manage_passwords_icon_views.h",
-        "views/payments/credit_card_editor_view_controller.cc",
-        "views/payments/credit_card_editor_view_controller.h",
-        "views/payments/editor_view_controller.cc",
-        "views/payments/editor_view_controller.h",
-        "views/payments/order_summary_view_controller.cc",
-        "views/payments/order_summary_view_controller.h",
-        "views/payments/payment_method_view_controller.cc",
-        "views/payments/payment_method_view_controller.h",
-        "views/payments/payment_request_dialog_view.cc",
-        "views/payments/payment_request_dialog_view.h",
-        "views/payments/payment_request_dialog_view_ids.h",
-        "views/payments/payment_request_row_view.cc",
-        "views/payments/payment_request_row_view.h",
-        "views/payments/payment_request_sheet_controller.cc",
-        "views/payments/payment_request_sheet_controller.h",
-        "views/payments/payment_request_views_util.cc",
-        "views/payments/payment_request_views_util.h",
-        "views/payments/payment_sheet_view_controller.cc",
-        "views/payments/payment_sheet_view_controller.h",
-        "views/payments/shipping_list_view_controller.cc",
-        "views/payments/shipping_list_view_controller.h",
-        "views/payments/validating_textfield.cc",
-        "views/payments/validating_textfield.h",
-        "views/payments/view_stack.cc",
-        "views/payments/view_stack.h",

[please use gerrit instead, 2017/02/10 16:40:27]

These files are included if "mac_views_browser" is true, so moving these lines
is not necessary, right?

[tmartino, 2017/02/10 17:41:16]

No, mac_views_browser is currently false. That's basically the last step of the
MacViews rollout, and it's not a dependency for PaymentRequest.

         "views/process_singleton_dialog_linux.cc",
         "views/profiles/profile_indicator_icon.cc",
         "views/profiles/profile_indicator_icon.h",
@@ -2142,7 +2142,7 @@ split_static_library("ui") {
       "webui/settings/native_certificates_handler.h",
     ]
   }
-  if (is_win || is_linux) {
+  if (is_win || is_linux || is_mac) {

[please use gerrit instead, 2017/02/10 16:40:27]

Does Chrome OS fall under is_linux umbrella here?

[tmartino, 2017/02/10 17:41:16]

Yes.

https://cs.chromium.org/chromium/src/build/config/BUILDCONFIG.gn?type=cs&l=271

FYI is_desktop_linux checks for strictly non-CrOS, non-Android Linux.

[please use gerrit instead, 2017/02/10 17:45:08]

Perhaps this should be !is_android instead.

     deps += [
       "//components/payments:payment_request_impl",
       "//components/payments:payment_validation",