Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2687023007: Revert of Browser tests for using the new SafeBrowsing protocol (v4) (Closed)

Created:
3 years, 10 months ago by hiroshige
Modified:
3 years, 10 months ago
CC:
chromium-reviews, grt+watch_chromium.org, vakh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Browser tests for using the new SafeBrowsing protocol (v4) (patchset #8 id:220001 of https://codereview.chromium.org/2675063002/ ) Reason for revert: Suspected to cause sizes test failing due to static initializers added to v4_database.cc. BUG=691069 Original issue's description: > Adding browser tests for PVer4. > > Just adding some basic tests for now. > More coming soon (http://crrev.com/2684663002) > > BUG=682495 > > Review-Url: https://codereview.chromium.org/2675063002 > Cr-Commit-Position: refs/heads/master@{#449703} > Committed: https://chromium.googlesource.com/chromium/src/+/d9bfc537eac0e031058b6df63b4290a645318cf8 TBR=asanka@chromium.org,csharrison@chromium.org,nparker@chromium.org,shess@chromium.org,vakh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=682495 Review-Url: https://codereview.chromium.org/2687023007 Cr-Commit-Position: refs/heads/master@{#449731} Committed: https://chromium.googlesource.com/chromium/src/+/97c42c445521b0f145afb0603bf7a38d4266e7dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -447 lines) Patch
M chrome/browser/download/download_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/loader/safe_browsing_resource_throttle.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.h View 3 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 9 chunks +11 lines, -15 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 8 chunks +5 lines, -306 lines 0 comments Download
M chrome/browser/safe_browsing/services_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/services_delegate_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/services_delegate_impl.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/services_delegate_stub.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/services_delegate_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/test_safe_browsing_service.h View 3 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/test_safe_browsing_service.cc View 2 chunks +5 lines, -11 lines 0 comments Download
M components/safe_browsing_db/v4_database.h View 5 chunks +9 lines, -21 lines 0 comments Download
M components/safe_browsing_db/v4_database.cc View 4 chunks +8 lines, -22 lines 0 comments Download
M components/safe_browsing_db/v4_database_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/safe_browsing_db/v4_feature_list.h View 1 chunk +10 lines, -13 lines 0 comments Download
M components/safe_browsing_db/v4_feature_list.cc View 1 chunk +12 lines, -16 lines 0 comments Download
M components/safe_browsing_db/v4_get_hash_protocol_manager.h View 2 chunks +3 lines, -4 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/safe_browsing_db/v4_store.h View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hiroshige
Created Revert of Browser tests for using the new SafeBrowsing protocol (v4)
3 years, 10 months ago (2017-02-10 20:54:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687023007/1
3 years, 10 months ago (2017-02-10 20:54:50 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 21:00:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/97c42c445521b0f145afb0603bf7...

Powered by Google App Engine
This is Rietveld 408576698