Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2687023004: reintroduce InterceptDownloadResourceThrottle for some OMA DRM downloads (Closed)

Created:
3 years, 10 months ago by qinmin
Modified:
3 years, 10 months ago
CC:
chromium-reviews, asanka, loading-reviews_chromium.org, Randy Smith (Not in Mondays), mmenke, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

reintroduce InterceptDownloadResourceThrottle for some OMA DRM downloads For OMA DRM downloads, if download descriptor file doesn't exist, Android DownloadManager should be used. This CL reverts some of the changes in https://codereview.chromium.org/2341643008 to intercept such downloads. TBR=dtrainor@chromium.org,thakis@chromium.org BUG=675559 Review-Url: https://codereview.chromium.org/2642683005 Cr-Commit-Position: refs/heads/master@{#449100} (cherry picked from commit 1dfa16b2126e9776a3e26f00b4c767b83f2645b5) Review-Url: https://codereview.chromium.org/2687023004 . Cr-Commit-Position: refs/branch-heads/2987@{#408} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/7f38b5828681175efbfac85432cd1527a68b1eff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -12 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/android/download/chrome_download_delegate.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/android/download/chrome_download_delegate.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M chrome/browser/android/download/download_controller.h View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/android/download/download_controller.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M chrome/browser/android/download/download_controller_base.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/android/download/download_controller_base.cc View 2 chunks +1 line, -6 lines 0 comments Download
A chrome/browser/android/download/intercept_download_resource_throttle.h View 1 chunk +42 lines, -0 lines 0 comments Download
A chrome/browser/android/download/intercept_download_resource_throttle.cc View 1 chunk +86 lines, -0 lines 0 comments Download
M chrome/browser/android/download/mock_download_controller.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/android/download/mock_download_controller.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
qinmin
3 years, 10 months ago (2017-02-09 17:17:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7f38b5828681175efbfac85432cd1527a68b1eff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698