Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1868)

Issue 2687013006: Add doc for vscode (Closed)

Created:
3 years, 10 months ago by chaopeng
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add doc for vscode BUG= Review-Url: https://codereview.chromium.org/2687013006 Cr-Commit-Position: refs/heads/master@{#449883} Committed: https://chromium.googlesource.com/chromium/src/+/ba312ce74654e54790202de6afa9987d38a7965b

Patch Set 1 #

Total comments: 4

Patch Set 2 : rouslan comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -0 lines) Patch
A docs/vscode.md View 1 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687013006/1
3 years, 10 months ago (2017-02-11 01:12:38 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-11 01:12:43 UTC) #4
chaopeng
PTAL. Thank you.
3 years, 10 months ago (2017-02-11 01:15:52 UTC) #6
please use gerrit instead
https://codereview.chromium.org/2687013006/diff/1/docs/vscode.md File docs/vscode.md (right): https://codereview.chromium.org/2687013006/diff/1/docs/vscode.md#newcode5 docs/vscode.md:5: multi-platform code editor that is itself based on Electron ...
3 years, 10 months ago (2017-02-11 22:35:24 UTC) #7
chaopeng
Updated, PTAL. Thank you.
3 years, 10 months ago (2017-02-12 02:40:36 UTC) #8
please use gerrit instead
lgtm
3 years, 10 months ago (2017-02-12 03:12:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687013006/20001
3 years, 10 months ago (2017-02-12 03:13:27 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-12 03:39:25 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ba312ce74654e54790202de6afa9...

Powered by Google App Engine
This is Rietveld 408576698