DevTools RDP: add parameters to DOMDebugger.getEventListeners

DevTools RDP: add parameters to DOMDebugger.getEventListeners

BUG=688537
Review-Url: https://codereview.chromium.org/2687003002
Cr-Commit-Position: refs/heads/master@{#449530}
Committed: https://chromium.googlesource.com/chromium/src/+/d9c65ab57b963b4f448f4b123ab1caee7b8509ee

[pfeldman, 2017-02-09 01:02:01]

pfeldman@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2017-02-09 21:09:22]

lgtm

https://codereview.chromium.org/2687003002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp (right):

https://codereview.chromium.org/2687003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp:1901:
result->push_back(node);
can we avoid collecting all nodes when we only need a few?

https://codereview.chromium.org/2687003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp:1910:
frameOwner->contentFrame()->isLocalFrame()
use frameOwner->isLocal() instead and get rid of frame altogether.

https://codereview.chromium.org/2687003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp:1937:
collectNodes(child, depth, pierce, result);
{}

https://codereview.chromium.org/2687003002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
(right):

https://codereview.chromium.org/2687003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp:45:
namespace blink {
revert this change.

https://codereview.chromium.org/2687003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp:182:
v8::Local<v8::Value> value,
let's give it a more descriptive name

https://codereview.chromium.org/2687003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp:254:
HeapVector<Member<Node>> nodes;
move down to usage

https://codereview.chromium.org/2687003002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
(right):

https://codereview.chromium.org/2687003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h:112:
V8EventListenerInfoList& listeners,
Make it last.

[pfeldman, 2017-02-09 21:51:18]

https://codereview.chromium.org/2687003002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp (right):

https://codereview.chromium.org/2687003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp:1901:
result->push_back(node);
On 2017/02/09 21:09:21, caseq wrote:
> can we avoid collecting all nodes when we only need a few?

Done.

https://codereview.chromium.org/2687003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp:1910:
frameOwner->contentFrame()->isLocalFrame()
On 2017/02/09 21:09:21, caseq wrote:
> use frameOwner->isLocal() instead and get rid of frame altogether.

Done.

https://codereview.chromium.org/2687003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp:1937:
collectNodes(child, depth, pierce, result);
On 2017/02/09 21:09:21, caseq wrote:
> {}

Done.

https://codereview.chromium.org/2687003002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
(right):

https://codereview.chromium.org/2687003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp:182:
v8::Local<v8::Value> value,
On 2017/02/09 21:09:21, caseq wrote:
> let's give it a more descriptive name

Done.

https://codereview.chromium.org/2687003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp:254:
HeapVector<Member<Node>> nodes;
On 2017/02/09 21:09:21, caseq wrote:
> move down to usage

Done.

[pfeldman, 2017-02-09 21:51:22]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-02-09 21:51:22]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2687003002/#ps20001
(title: "review comments addressed")

[commit-bot: I haz the power, 2017-02-09 21:52:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 00:29:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 00:29:32]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2017-02-10 00:43:55]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-02-10 00:43:56]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2687003002/#ps40001
(title: "f-e compile")

[commit-bot: I haz the power, 2017-02-10 00:44:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 02:38:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486687435669630,
"parent_rev": "fc6825e49d0c5aa1a922cf3b260e67070835abfb", "commit_rev":
"d9c65ab57b963b4f448f4b123ab1caee7b8509ee"}

[commit-bot: I haz the power, 2017-02-10 02:38:53]

Description was changed from

==========
DevTools RDP: add parameters to DOMDebugger.getEventListeners

BUG=688537
==========

to

==========
DevTools RDP: add parameters to DOMDebugger.getEventListeners

BUG=688537

Review-Url: https://codereview.chromium.org/2687003002
Cr-Commit-Position: refs/heads/master@{#449530}
Committed:
https://chromium.googlesource.com/chromium/src/+/d9c65ab57b963b4f448f4b123ab1...
==========

[commit-bot: I haz the power, 2017-02-10 02:39:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d9c65ab57b963b4f448f4b123ab1...