Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 2686953002: Mark http/tests/security/frameNavigation/xss-ALLOWED-top-navigation-after-postMessage.html un-flaky (Closed)

Created:
3 years, 10 months ago by Nate Chapin
Modified:
3 years, 10 months ago
Reviewers:
alexmos
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark http/tests/security/frameNavigation/xss-ALLOWED-top-navigation-after-postMessage.html un-flaky This was failing rather than timing out until https://chromium.googlesource.com/chromium/src/+/61835ae17fb417e72d42d7e4829c755c5abdb578, which returned it to its expected timeout state. BUG=680249 Review-Url: https://codereview.chromium.org/2686953002 Cr-Commit-Position: refs/heads/master@{#449164} Committed: https://chromium.googlesource.com/chromium/src/+/23d0ec854822ed5b94d08c84a9db55270bdece43

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Nate Chapin
PTAL
3 years, 10 months ago (2017-02-08 23:32:36 UTC) #4
alexmos
LGTM
3 years, 10 months ago (2017-02-08 23:47:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686953002/1
3 years, 10 months ago (2017-02-09 00:07:50 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 00:48:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/23d0ec854822ed5b94d08c84a9db...

Powered by Google App Engine
This is Rietveld 408576698