Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: chrome/browser/ui/browser_navigator_params.h

Issue 2686943002: New WebContents created via ctrl-click should be in a new process. (Closed)
Patch Set: No need to send the new boolean flag over IPC. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_navigator_params.h
diff --git a/chrome/browser/ui/browser_navigator_params.h b/chrome/browser/ui/browser_navigator_params.h
index bf40e6781e709db6d8311cab5e6e07366d3a143d..fa8d359a6deea7a8021b0917dc3bf5eb9d75f159 100644
--- a/chrome/browser/ui/browser_navigator_params.h
+++ b/chrome/browser/ui/browser_navigator_params.h
@@ -132,6 +132,14 @@ struct NavigateParams {
// |tabstrip_add_types|.
WindowOpenDisposition disposition;
+ // Controls whether newly created web contents (in case if |disposition| asks
Charlie Reis 2017/04/19 20:11:11 nit: Drop "if"
Łukasz Anforowicz 2017/04/20 01:11:29 Done.
+ // for a new tab or window) should attempt to reuse the renderer process of
+ // |source_site_instance|. For example - new contents created after
+ // ctrl-clicking a link should use always a new renderer, but
+ // chrome.windows.create extensions API should try to keep the new contents in
+ // the same extension process (if same-site).
+ bool use_new_renderer_for_new_contents;
Charlie Reis 2017/04/19 20:11:11 I'm trying to think of alternatives for the name (
+
// Sets browser->is_trusted_source. Default is false.
bool trusted_source;

Powered by Google App Engine
This is Rietveld 408576698