Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Side by Side Diff: chrome/browser/ui/browser_navigator_params.h

Issue 2686943002: New WebContents created via ctrl-click should be in a new process. (Closed)
Patch Set: No need to send the new boolean flag over IPC. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_NAVIGATOR_PARAMS_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_NAVIGATOR_PARAMS_H_
6 #define CHROME_BROWSER_UI_BROWSER_NAVIGATOR_PARAMS_H_ 6 #define CHROME_BROWSER_UI_BROWSER_NAVIGATOR_PARAMS_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 // CURRENT_TAB " " " NEW_FOREGROUND_TAB 125 // CURRENT_TAB " " " NEW_FOREGROUND_TAB
126 // OFF_THE_RECORD target browser profile is incog. NEW_FOREGROUND_TAB 126 // OFF_THE_RECORD target browser profile is incog. NEW_FOREGROUND_TAB
127 // 127 //
128 // If disposition is NEW_BACKGROUND_TAB, TabStripModel::ADD_ACTIVE is 128 // If disposition is NEW_BACKGROUND_TAB, TabStripModel::ADD_ACTIVE is
129 // removed from |tabstrip_add_types| automatically. 129 // removed from |tabstrip_add_types| automatically.
130 // If disposition is one of NEW_WINDOW, NEW_POPUP, NEW_FOREGROUND_TAB or 130 // If disposition is one of NEW_WINDOW, NEW_POPUP, NEW_FOREGROUND_TAB or
131 // SINGLETON_TAB, then TabStripModel::ADD_ACTIVE is automatically added to 131 // SINGLETON_TAB, then TabStripModel::ADD_ACTIVE is automatically added to
132 // |tabstrip_add_types|. 132 // |tabstrip_add_types|.
133 WindowOpenDisposition disposition; 133 WindowOpenDisposition disposition;
134 134
135 // Controls whether newly created web contents (in case if |disposition| asks
Charlie Reis 2017/04/19 20:11:11 nit: Drop "if"
Łukasz Anforowicz 2017/04/20 01:11:29 Done.
136 // for a new tab or window) should attempt to reuse the renderer process of
137 // |source_site_instance|. For example - new contents created after
138 // ctrl-clicking a link should use always a new renderer, but
139 // chrome.windows.create extensions API should try to keep the new contents in
140 // the same extension process (if same-site).
141 bool use_new_renderer_for_new_contents;
Charlie Reis 2017/04/19 20:11:11 I'm trying to think of alternatives for the name (
142
135 // Sets browser->is_trusted_source. Default is false. 143 // Sets browser->is_trusted_source. Default is false.
136 bool trusted_source; 144 bool trusted_source;
137 145
138 // The transition type of the navigation. Default is 146 // The transition type of the navigation. Default is
139 // ui::PAGE_TRANSITION_LINK when target_contents is specified in the 147 // ui::PAGE_TRANSITION_LINK when target_contents is specified in the
140 // constructor. 148 // constructor.
141 ui::PageTransition transition; 149 ui::PageTransition transition;
142 150
143 // Whether this navigation was initiated by the renderer process. Default is 151 // Whether this navigation was initiated by the renderer process. Default is
144 // false. 152 // false.
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 NavigateParams(); 255 NavigateParams();
248 }; 256 };
249 257
250 // Copies fields from |params| struct to |nav_params| struct. 258 // Copies fields from |params| struct to |nav_params| struct.
251 void FillNavigateParamsFromOpenURLParams(chrome::NavigateParams* nav_params, 259 void FillNavigateParamsFromOpenURLParams(chrome::NavigateParams* nav_params,
252 const content::OpenURLParams& params); 260 const content::OpenURLParams& params);
253 261
254 } // namespace chrome 262 } // namespace chrome
255 263
256 #endif // CHROME_BROWSER_UI_BROWSER_NAVIGATOR_PARAMS_H_ 264 #endif // CHROME_BROWSER_UI_BROWSER_NAVIGATOR_PARAMS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698