Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2686913003: [ObjC ARC] Converts ios/chrome/browser/ui/dialogs:unit_tests_internal to ARC. (Closed)

Created:
3 years, 10 months ago by lody
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/dialogs:unit_tests_internal to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2686913003 Cr-Commit-Position: refs/heads/master@{#449281} Committed: https://chromium.googlesource.com/chromium/src/+/0284803bf5636ccc4789b933121664939478bad9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -15 lines) Patch
M ios/chrome/browser/ui/dialogs/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/dialogs/dialog_presenter_unittest.mm View 3 chunks +7 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/dialogs/nsurl_protection_space_util_unittest.mm View 4 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
lody
Please review, thank you
3 years, 10 months ago (2017-02-09 12:39:07 UTC) #6
marq (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-09 13:42:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686913003/1
3 years, 10 months ago (2017-02-09 13:44:00 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 13:48:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0284803bf5636ccc4789b9331216...

Powered by Google App Engine
This is Rietveld 408576698