Description[Chromecast] Add /system/chrome to the rpath for component builds.
We recently hit a corner case on the component build from the following
dependency structure:
/chrome/crash_uploader ("//chromecast/crash:crash_uploader") ->
/chrome/lib/libcast_reboot_1.0.so ("//chromecast/system/reboot") ->
/chrome/libnet.so ("//net")
In libcast_reboot_1.0.so's RPATH, $ORIGIN resolves to /chrome/lib,
meaning that it never searches /chrome/ for libnet.so, causing it to
crash. Explicitly adding the location of component libs to the RPATH
solves this issue.
Note: The RPATH will not be changed in production builds, which do not
use the component build.
BUG=
Change-Id: I0646a063ad787d3fe846fd0755f7f84a4cb6033b
Review-Url: https://codereview.chromium.org/2686903002
Cr-Commit-Position: refs/heads/master@{#449130}
Committed: https://chromium.googlesource.com/chromium/src/+/3301fc1e1974b51ccb59f24519de0dcde34b9333
Patch Set 1 #
Messages
Total messages: 9 (4 generated)
|