Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2686903002: [Chromecast] Add /system/chrome to the rpath for component builds. (Closed)

Created:
3 years, 10 months ago by slan
Modified:
3 years, 10 months ago
Reviewers:
Dirk Pranke, halliwell, bcf
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Add /system/chrome to the rpath for component builds. We recently hit a corner case on the component build from the following dependency structure: /chrome/crash_uploader ("//chromecast/crash:crash_uploader") -> /chrome/lib/libcast_reboot_1.0.so ("//chromecast/system/reboot") -> /chrome/libnet.so ("//net") In libcast_reboot_1.0.so's RPATH, $ORIGIN resolves to /chrome/lib, meaning that it never searches /chrome/ for libnet.so, causing it to crash. Explicitly adding the location of component libs to the RPATH solves this issue. Note: The RPATH will not be changed in production builds, which do not use the component build. BUG= Change-Id: I0646a063ad787d3fe846fd0755f7f84a4cb6033b Review-Url: https://codereview.chromium.org/2686903002 Cr-Commit-Position: refs/heads/master@{#449130} Committed: https://chromium.googlesource.com/chromium/src/+/3301fc1e1974b51ccb59f24519de0dcde34b9333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/config/chromecast/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
slan
+Dirk for OWNERS
3 years, 10 months ago (2017-02-08 21:06:40 UTC) #2
Dirk Pranke
lgtm
3 years, 10 months ago (2017-02-08 21:25:17 UTC) #3
bcf
lgtm
3 years, 10 months ago (2017-02-08 21:28:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686903002/1
3 years, 10 months ago (2017-02-08 21:29:40 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 23:14:46 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3301fc1e1974b51ccb59f24519de...

Powered by Google App Engine
This is Rietveld 408576698