Issue 26869004: Merge 227483 "Views Textfield/Omnibox: Do not paste on Ctrl+Alt[..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26869004: Merge 227483 "Views Textfield/Omnibox: Do not paste on Ctrl+Alt[..." (Closed)

Created:
7 years, 2 months ago by msw

Modified:
7 years, 2 months ago

Reviewers:
msw

CC:
chromium-reviews, nona+watch_chromium.org, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1650/src/

Visibility:
Public.

More Reviews

Description

Merge 227483 "Views Textfield/Omnibox: Do not paste on Ctrl+Alt[..." > Views Textfield/Omnibox: Do not paste on Ctrl+Alt[Gr]+V or AltGr+V. > > Make the Views Omnibox and Textfield treat AltGr as Alt. > (This is the right alt key on Hungarian, Polish, etc. keyboards) > (Hungarian users press AltGr+V for "@" etc.) > > Make the Views Omnibox not paste on Ctrl+Alt+V (matches Win & Mac). > (The Views Textfield already does not paste if Alt is pressed) > > Add a test that Ctrl/Cmd+Alt+V does not paste. > > TODO(msw): Test that AltGr+V does not invoke paste. > (We don't have common test infrastructure to press AltGr) > > BUG=303073 > TEST=Ctrl+Alt+V, Ctrl+AltGr+V, and AltGr+V do not paste in the Omnibox or Find Bar, etc. (Add Hungarian or Polish keyboard layouts, use the Right-Alt or on-screen keyboard for the AltGr button). > R=pkasting@chromium.org > > Review URL: https://codereview.chromium.org/26248004 TBR=msw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227960

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -11 lines)			Patch
M	chrome/browser/ui/omnibox/omnibox_view_browsertest.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_view_views.cc	View	3 chunks	+8 lines, -10 lines	0 comments	Download
M	ui/views/controls/textfield/native_textfield_views.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r227960.

Expand Messages | Collapse Messages