Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Issue 26248004: Views Textfield/Omnibox: Do not paste on Ctrl+Alt[Gr]+V or AltGr+V. (Closed)

Created:
7 years, 2 months ago by msw
Modified:
7 years, 2 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, nona+watch_chromium.org, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Views Textfield/Omnibox: Do not paste on Ctrl+Alt[Gr]+V or AltGr+V. Make the Views Omnibox and Textfield treat AltGr as Alt. (This is the right alt key on Hungarian, Polish, etc. keyboards) (Hungarian users press AltGr+V for "@" etc.) Make the Views Omnibox not paste on Ctrl+Alt+V (matches Win & Mac). (The Views Textfield already does not paste if Alt is pressed) Add a test that Ctrl/Cmd+Alt+V does not paste. TODO(msw): Test that AltGr+V does not invoke paste. (We don't have common test infrastructure to press AltGr) BUG=303073 TEST=Ctrl+Alt+V, Ctrl+AltGr+V, and AltGr+V do not paste in the Omnibox or Find Bar, etc. (Add Hungarian or Polish keyboard layouts, use the Right-Alt or on-screen keyboard for the AltGr button). R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227483

Patch Set 1 #

Patch Set 2 : Remove unsupported AltGr test cases. #

Total comments: 2

Patch Set 3 : Simplify test comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 3 chunks +8 lines, -10 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
msw
Hey Peter, please take a look; thanks!
7 years, 2 months ago (2013-10-08 02:17:18 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/26248004/diff/3001/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc File chrome/browser/ui/omnibox/omnibox_view_browsertest.cc (right): https://codereview.chromium.org/26248004/diff/3001/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc#newcode1585 chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1585: // The Alt key should stifle the Control+V ...
7 years, 2 months ago (2013-10-08 02:38:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/26248004/22001
7 years, 2 months ago (2013-10-08 03:35:06 UTC) #3
msw
Done; landing. https://codereview.chromium.org/26248004/diff/3001/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc File chrome/browser/ui/omnibox/omnibox_view_browsertest.cc (right): https://codereview.chromium.org/26248004/diff/3001/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc#newcode1585 chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1585: // The Alt key should stifle the ...
7 years, 2 months ago (2013-10-08 03:37:48 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-08 03:44:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/26248004/22001
7 years, 2 months ago (2013-10-08 05:31:52 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-08 07:03:41 UTC) #7
Message was sent while issue was closed.
Change committed as 227483

Powered by Google App Engine
This is Rietveld 408576698