Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2686883003: Remove non-MD test coverage form ShelfViewTest and subclasses (Closed)

Created:
3 years, 10 months ago by mohsen
Modified:
3 years, 10 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-MD test coverage form ShelfViewTest and subclasses Removed touch feedback tests from ShelfViewTest as it is a non-MD feature. Also removed forcing EXPERIMENTAL mode in ShelfViewInkDropTest and its subclasses as ink drop is graduated out of experimental; and material mode is on by default. BUG=685837 TEST=ShelfViewTest.*, ShelfViewInkDropTest.*, OverflowButtonInkDropTest.*, OverflowButtonActiveInkDropTest.* in ash_unittests Review-Url: https://codereview.chromium.org/2686883003 Cr-Commit-Position: refs/heads/master@{#449323} Committed: https://chromium.googlesource.com/chromium/src/+/58067513307e4ab9d0bd473670cf3fa883aa0f6a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -53 lines) Patch
M ash/shelf/shelf_view_unittest.cc View 4 chunks +1 line, -53 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mohsen
Please take a look...
3 years, 10 months ago (2017-02-09 04:07:06 UTC) #6
James Cook
LGTM
3 years, 10 months ago (2017-02-09 15:21:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686883003/1
3 years, 10 months ago (2017-02-09 16:51:40 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 16:58:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/58067513307e4ab9d0bd473670cf...

Powered by Google App Engine
This is Rietveld 408576698