Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2686873003: Make MessageLoopRunner be RefCountedThreadSafe (Closed)

Created:
3 years, 10 months ago by tzik
Modified:
3 years, 10 months ago
Reviewers:
kinuko
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make MessageLoopRunner be RefCountedThreadSafe MessageLoopRunner has a non-thread-safe ref count and is used from multiple threads in tests. Review-Url: https://codereview.chromium.org/2686873003 Cr-Commit-Position: refs/heads/master@{#449235} Committed: https://chromium.googlesource.com/chromium/src/+/0c4ab45b18a9e054f9135d0c2cf74f7d1bb77a97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/public/test/test_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tzik
PTAL
3 years, 10 months ago (2017-02-09 06:50:17 UTC) #5
kinuko
Is this one still used a lot? (Did code search--> looks like it is. :( ...
3 years, 10 months ago (2017-02-09 07:13:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686873003/1
3 years, 10 months ago (2017-02-09 07:57:29 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 08:35:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0c4ab45b18a9e054f9135d0c2cf7...

Powered by Google App Engine
This is Rietveld 408576698