Move IsAboutBlank from url_utils to GURL

Move IsAboutBlank from url_utils to GURL

https://codereview.chromium.org/2644133002/ introduced a IsAboutBlank
function to recognize urls of the form about:blank/#foo &
about:blank?foo. It was mistaknely placed in url_utils.h which should
not depend on GURL. This CL moves the function to GURL.h.

BUG=575210
Review-Url: https://codereview.chromium.org/2686853004
Cr-Commit-Position: refs/heads/master@{#449624}
Committed: https://chromium.googlesource.com/chromium/src/+/12bca18ba5d9a9756cbe87bbc10c92ea7e402f9a

[clamy, 2017-02-09 13:25:37]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 13:25:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 14:57:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 14:57:50]

Dry run: This issue passed the CQ dry run.

[clamy, 2017-02-09 14:58:18]

Description was changed from

==========
Move IsAboutBlank from url_utils to GURL

https://codereview.chromium.org/2644133002/ introduced a IsAboutBlank
function to recognize urls of the form about:blank/#foo &
about:blank?foo. It was mistaknely placed in url_utils.h which should
not depend on GURL. This CL moves the function to GURL.h.

BUG=575210
==========

to

==========
Move IsAboutBlank from url_utils to GURL

https://codereview.chromium.org/2644133002/ introduced a IsAboutBlank
function to recognize urls of the form about:blank/#foo &
about:blank?foo. It was mistaknely placed in url_utils.h which should
not depend on GURL. This CL moves the function to GURL.h.

BUG=575210
==========

[clamy, 2017-02-09 14:58:19]

clamy@chromium.org changed reviewers:
+ brettw@chromium.org

[clamy, 2017-02-09 15:00:32]

@brettw: PTAL. This is a follow up on
https://codereview.chromium.org/2644133002/. Unfortunately, using
EqualsIgnoringRef does not work here: we want to return true for about:blank?foo
(it would be false). Also the # version of about:blank is about:blank/#foo,
where EqualsIgnoringRef returns false since about:blank is not equal to
about:blank/.

[brettw, 2017-02-09 20:30:29]

LGTM, thanks!

https://codereview.chromium.org/2686853004/diff/1/url/gurl.cc
File url/gurl.cc (right):

https://codereview.chromium.org/2686853004/diff/1/url/gurl.cc#newcode355
url/gurl.cc:355: if (has_host() || has_username() || has_password() ||
has_port()) {
Remove {} for consistency.

[clamy, 2017-02-10 13:17:22]

Thanks!

https://codereview.chromium.org/2686853004/diff/1/url/gurl.cc
File url/gurl.cc (right):

https://codereview.chromium.org/2686853004/diff/1/url/gurl.cc#newcode355
url/gurl.cc:355: if (has_host() || has_username() || has_password() ||
has_port()) {
On 2017/02/09 20:30:28, brettw (plz ping after 24h) wrote:
> Remove {} for consistency.

Done.

[clamy, 2017-02-10 13:17:35]

The CQ bit was checked by clamy@chromium.org

[clamy, 2017-02-10 13:17:35]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2686853004/#ps20001
(title: "Addressed nit")

[commit-bot: I haz the power, 2017-02-10 13:17:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 15:33:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486732655343770,
"parent_rev": "9d60f1ffae4744d1130369ace717d03eaaf0f216", "commit_rev":
"12bca18ba5d9a9756cbe87bbc10c92ea7e402f9a"}

[commit-bot: I haz the power, 2017-02-10 15:33:46]

Description was changed from

==========
Move IsAboutBlank from url_utils to GURL

https://codereview.chromium.org/2644133002/ introduced a IsAboutBlank
function to recognize urls of the form about:blank/#foo &
about:blank?foo. It was mistaknely placed in url_utils.h which should
not depend on GURL. This CL moves the function to GURL.h.

BUG=575210
==========

to

==========
Move IsAboutBlank from url_utils to GURL

https://codereview.chromium.org/2644133002/ introduced a IsAboutBlank
function to recognize urls of the form about:blank/#foo &
about:blank?foo. It was mistaknely placed in url_utils.h which should
not depend on GURL. This CL moves the function to GURL.h.

BUG=575210

Review-Url: https://codereview.chromium.org/2686853004
Cr-Commit-Position: refs/heads/master@{#449624}
Committed:
https://chromium.googlesource.com/chromium/src/+/12bca18ba5d9a9756cbe87bbc10c...
==========

[commit-bot: I haz the power, 2017-02-10 15:33:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/12bca18ba5d9a9756cbe87bbc10c...