Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2686853003: Mark WebglConformance_deqp_functional_gles3_sync as Fail (Closed)

Created:
3 years, 10 months ago by ynovikov
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark WebglConformance_deqp_functional_gles3_sync as Fail Flaky fails all 3 retries on Mac ASAN bot. BUG=676848 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2686853003 Cr-Commit-Position: refs/heads/master@{#449108} Committed: https://chromium.googlesource.com/chromium/src/+/9cb6cef367150495dc15eb0e20525752fe9e198e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
ynovikov
Not sure if there is a way to have it Fail on Mac ASAN and ...
3 years, 10 months ago (2017-02-08 20:11:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686853003/1
3 years, 10 months ago (2017-02-08 20:12:32 UTC) #4
ynovikov
Aha, it also failed 3 retries in Release without ASAN here: https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/6856 So, having it ...
3 years, 10 months ago (2017-02-08 21:10:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9cb6cef367150495dc15eb0e20525752fe9e198e
3 years, 10 months ago (2017-02-08 22:25:29 UTC) #8
Ken Russell (switch to Gerrit)
On 2017/02/08 20:11:44, ynovikov wrote: > Not sure if there is a way to have ...
3 years, 10 months ago (2017-02-14 04:38:58 UTC) #9
Ken Russell (switch to Gerrit)
3 years, 10 months ago (2017-02-14 04:39:15 UTC) #10
Message was sent while issue was closed.
On 2017/02/14 04:38:58, Ken Russell wrote:
> On 2017/02/08 20:11:44, ynovikov wrote:
> > Not sure if there is a way to have it Fail on Mac ASAN and Flaky everywhere
> > else.
> 
> There is:
> 
> self.Fail('deqp/functional/gles3/sync.html', ['mac', 'asan'], bug=676848)
> self.Fail('deqp/functional/gles3/sync.html', ['no_asan'], bug=676848)
> 
> or similar.

Sorry, meant "self.Flaky" on the second line there.

Powered by Google App Engine
This is Rietveld 408576698